linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Jamie Lokier <jamie@shareable.org>
Cc: rusty@rustcorp.com.au, hugh@veritas.com, drepper@redhat.com,
	lk@tantalophile.demon.co.uk, shemminger@osdl.org,
	torvalds@transmeta.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Re: today's futex changes
Date: Mon, 8 Sep 2003 12:59:32 -0700	[thread overview]
Message-ID: <20030908125932.777f2585.akpm@osdl.org> (raw)
In-Reply-To: <20030908200741.GH27097@mail.jlokier.co.uk>

Jamie Lokier <jamie@shareable.org> wrote:
>
> Andrew Morton wrote:
> > Rusty Russell <rusty@rustcorp.com.au> wrote:
> > > D: 4) Andrew Morton says spurious wakeup is a bug.  Catch it.
> > 
> > Yes, but going BUG() is a bit rude.  We can detect the error, we can
> > recover from it and it doesn't cause any user data corruption or anything.
> > A rude printk is all that is needed here.
> 
> Well, it should really _never_ happen.  We are very careful.  Is
> there something like BUG() which doesn't terminate the process?
> 

A WARN_ON(1) is good enough.  It will spit a stack dump and we will get to
hear about it.  Going BUG merely reduces the chances of the info hitting
the logs and irritates our testers.



  reply	other threads:[~2003-09-08 20:17 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-09-05 20:24 today's futex changes Ulrich Drepper
2003-09-05 22:24 ` Stephen Hemminger
2003-09-06 16:28 ` [PATCH] " Hugh Dickins
2003-09-06 17:32   ` Ulrich Drepper
2003-09-06 17:44     ` Jamie Lokier
2003-09-06 17:46   ` Jamie Lokier
2003-09-06 18:21     ` Hugh Dickins
2003-09-08  6:45   ` Rusty Russell
2003-09-08 17:33     ` Hugh Dickins
2003-09-08 17:51       ` Hugh Dickins
2003-09-09  1:37       ` Rusty Russell
2003-09-08 17:51     ` Jamie Lokier
2003-09-08 18:26       ` Jamie Lokier
2003-09-09  3:58       ` Rusty Russell
2003-09-10 11:39         ` Jamie Lokier
2003-09-10 22:00           ` Rusty Russell
2003-09-11 16:29             ` Jamie Lokier
2003-09-08 19:02     ` Andrew Morton
2003-09-08 20:07       ` Jamie Lokier
2003-09-08 19:59         ` Andrew Morton [this message]
2003-09-08 20:11         ` Linus Torvalds
2003-09-09  4:12       ` Rusty Russell
2003-09-08 17:04   ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030908125932.777f2585.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=drepper@redhat.com \
    --cc=hugh@veritas.com \
    --cc=jamie@shareable.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lk@tantalophile.demon.co.uk \
    --cc=rusty@rustcorp.com.au \
    --cc=shemminger@osdl.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).