From: Rene Rebe <rene.rebe@gmx.net>
To: benh@kernel.crashing.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: dmasound_pmac (2.4.x{,-benh}) does not restore mixer during PM-wake
Date: Wed, 10 Sep 2003 22:26:20 +0000 (UTC) [thread overview]
Message-ID: <20030910.222620.730549923.rene.rebe@gmx.net> (raw)
In-Reply-To: <1063221565.678.2.camel@gaston>
Hi,
On: Wed, 10 Sep 2003 21:19:25 +0200,
Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
>
> > The code in tas3004_leave_sleep() looks ok so ... any idea (maybe I
> > need to add a printk do test if it is really called?)?
>
> Either that or we need some delay after powering the chip back
> up and before we can write to its mixer ?
Ok, here we go:
...
PCI: Enabling bus mastering for device 10:18.0
host/usb-ohci.c: USB continue: usb-10:18.0 from host wakeup
PCI: Enabling bus mastering for device 10:19.0
host/usb-ohci.c: USB continue: usb-10:19.0 from host wakeup
eth0: resuming
adb: starting probe task...
adb devices: [2]: 2 c4 [3]: 3 1 [7]: 7 1f
ADB keyboard at 2, handler 1
ADB mouse at 3, handler set to 4 (trackpad)
adb: finished probe task...
RxR: 1
RxR: 2
tas: I2C byte write failed
udio jack plugged, muting speakers.
eth0: Link is up at 100 Mbps, half-duplex.
...
#
(I overread the "tas: I2C byte write failed" before ...)
Where I instrumented the code with:
static int
tas3004_leave_sleep(struct tas3004_data_t *self)
{
unsigned char mcr = (1<<6)+(2<<4)+(2<<2);
printk("RxR: 1\n");
if (!self)
return -1;
printk("RxR: 2\n");
/* Make sure something answers on the i2c bus */
if (tas3004_write_register(self, TAS3004_REG_MCR, &mcr,
WRITE_NORMAL | FORCE_WRITE) < 0)
return -1;
printk("RxR: 3\n");
so hm?!? - is the wakeup order of the devices incorrect (i2c needs to
be before damsound_pmac ...)?
> ben.
Sincerely yours,
René Rebe
- ROCK Linux stable release maintainer
--
René Rebe - Europe/Germany/Berlin
rene@rocklinux.org rene.rebe@gmx.net
http://www.rocklinux.org http://www.rocklinux.net/people/rene
http://gsmp.tfh-berlin.de/gsmp http://gsmp.tfh-berlin.de/rene
next prev parent reply other threads:[~2003-09-10 22:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-10 21:15 dmasound_pmac (2.4.x{,-benh}) does not restore mixer during PM-wake Rene Rebe
2003-09-10 19:19 ` Benjamin Herrenschmidt
2003-09-10 22:26 ` Rene Rebe [this message]
2003-09-11 6:35 ` Benjamin Herrenschmidt
2003-09-11 17:19 ` Rene Rebe
2003-09-25 18:01 ` Rene Rebe
2003-09-25 18:43 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030910.222620.730549923.rene.rebe@gmx.net \
--to=rene.rebe@gmx.net \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).