From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S265866AbTIJWGH (ORCPT ); Wed, 10 Sep 2003 18:06:07 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S265871AbTIJWGH (ORCPT ); Wed, 10 Sep 2003 18:06:07 -0400 Received: from fed1mtao08.cox.net ([68.6.19.123]:57758 "EHLO fed1mtao08.cox.net") by vger.kernel.org with ESMTP id S265866AbTIJWF7 (ORCPT ); Wed, 10 Sep 2003 18:05:59 -0400 Date: Wed, 10 Sep 2003 15:05:52 -0700 From: Tom Rini To: Adrian Bunk Cc: Eyal Lebedinsky , Kernel Mailing List , pavel@suse.cz Subject: Re: [patch] 2.6.0-test5: serio config broken? Message-ID: <20030910220552.GJ4559@ip68-0-152-218.tc.ph.cox.net> References: <3F5DBC1F.8DF1F07A@eyal.emu.id.au> <20030910110225.GC27368@fs.tum.de> <20030910155542.GD4559@ip68-0-152-218.tc.ph.cox.net> <20030910170610.GH27368@fs.tum.de> <20030910185902.GE4559@ip68-0-152-218.tc.ph.cox.net> <20030910191038.GK27368@fs.tum.de> <20030910193158.GF4559@ip68-0-152-218.tc.ph.cox.net> <20030910195544.GL27368@fs.tum.de> <20030910210443.GG4559@ip68-0-152-218.tc.ph.cox.net> <20030910215136.GP27368@fs.tum.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030910215136.GP27368@fs.tum.de> User-Agent: Mutt/1.5.4i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 10, 2003 at 11:51:37PM +0200, Adrian Bunk wrote: > On Wed, Sep 10, 2003 at 02:04:43PM -0700, Tom Rini wrote: > > On Wed, Sep 10, 2003 at 09:55:44PM +0200, Adrian Bunk wrote: > > > On Wed, Sep 10, 2003 at 12:31:58PM -0700, Tom Rini wrote: > > > >... > > > > ===== drivers/input/keyboard/Kconfig 1.6 vs edited ===== > > > > --- 1.6/drivers/input/keyboard/Kconfig Wed Jul 16 10:39:32 2003 > > > > +++ edited/drivers/input/keyboard/Kconfig Fri Sep 5 14:45:36 2003 > > > > @@ -2,8 +2,9 @@ > > > > # Input core configuration > > > > # > > > > config INPUT_KEYBOARD > > > > - bool "Keyboards" if EMBEDDED || !X86 > > > > + bool "Keyboards" > > > > default y > > > > + select KEYBOARD_ATKBD if STANDARD && X86 > > > > depends on INPUT > > > > help > > > > Say Y here, and a list of supported keyboards will be displayed. > > > > @@ -12,7 +13,7 @@ > > > > If unsure, say Y. > > > > > > > > config KEYBOARD_ATKBD > > > > - tristate "AT keyboard support" if EMBEDDED || !X86 > > > > + tristate "AT keyboard support" > > > > default y > > > > depends on INPUT && INPUT_KEYBOARD && SERIO > > > > help > > > > ===== drivers/input/serio/Kconfig 1.9 vs edited ===== > > > > --- 1.9/drivers/input/serio/Kconfig Wed Jul 16 10:39:32 2003 > > > > +++ edited/drivers/input/serio/Kconfig Fri Sep 5 14:45:36 2003 > > > > @@ -2,7 +2,8 @@ > > > > # Input core configuration > > > > # > > > > config SERIO > > > > - tristate "Serial i/o support (needed for keyboard and mouse)" > > > > + tristate "Serial i/o support (needed for keyboard and mouse)" if !(STANDARD && X86) > > > > + select SERIO_I8042 if STANDARD && X86 > > > > default y > > > > ---help--- > > > > Say Yes here if you have any input device that uses serial I/O to > > > > > > This works but seems fragile since everyone touching the dependencies > > > must know that the tristate dependencies of SERIO must always match the > > > select dependencies in INPUT_KEYBOARD. > > > > How so? SERIO only selects SERIO_* bits, and INPUT only selects INPUT* > > (and, imho, keyboard is input :)) bits. > >... > > Let's say you remove the X86 dependency in the select in INPUT_KEYBOARD. You mean: select KEYBOARD_ATKBD if STANDARD && X86 becomes: select KEYBOARD_ATKBD if STANDARD ? > If you select SERIO=m on !X86 (with EMBEDDED/STANDARD enabled) this will > select KEYBOARD_ATKBD=y... How? What you pick for SERIO does not select anything in INPUT. select is 'stronger' than the {bool,tristate} "Foo" if ... usage, so if you have broken dependancies you get a different kind of failure (link, as opposed to a shot foot) but IMHO it's more correct for restraints that are of the form: "Don't let the user shoot themseleves in the foot, easily". -- Tom Rini http://gate.crashing.org/~trini/