From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263454AbTIWXjK (ORCPT ); Tue, 23 Sep 2003 19:39:10 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263453AbTIWXjJ (ORCPT ); Tue, 23 Sep 2003 19:39:09 -0400 Received: from rth.ninka.net ([216.101.162.244]:8358 "EHLO rth.ninka.net") by vger.kernel.org with ESMTP id S263412AbTIWXjG (ORCPT ); Tue, 23 Sep 2003 19:39:06 -0400 Date: Tue, 23 Sep 2003 16:37:44 -0700 From: "David S. Miller" To: Andrew Morton Cc: willy@debian.org, schwab@suse.de, bcrl@kvack.org, tony.luck@intel.com, davidm@hpl.hp.com, davidm@napali.hpl.hp.com, peter@chubb.wattle.id.au, ak@suse.de, iod00d@hp.com, peterc@gelato.unsw.edu.au, linux-ns83820@kvack.org, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: NS83820 2.6.0-test5 driver seems unstable on IA64 Message-Id: <20030923163744.4b9bb4c7.davem@redhat.com> In-Reply-To: <20030923161529.5203ce4d.akpm@osdl.org> References: <20030923142925.A16490@kvack.org> <20030923115200.1f5b44df.davem@redhat.com> <20030923192804.GG13172@parcelfarce.linux.theplanet.co.uk> <20030923122200.258215a3.davem@redhat.com> <20030923161529.5203ce4d.akpm@osdl.org> X-Mailer: Sylpheed version 0.9.5 (GTK+ 1.2.10; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 23 Sep 2003 16:15:29 -0700 Andrew Morton wrote: > "David S. Miller" wrote: > > > > > That's not true; they could be avoided by using get_unaligned() and > > > put_unaligned(). You just don't want to because they'd make sparc suck. > > > > Not only sparc would be effected by this. Using {get,put}_unaligned() > > all over the networking would incur a penalty for many platforms, not > > just sparc. > > Really? I'd have thought that get/put_unaligned would be a simple > load/store for architectures which wish to implement it in that manner. Only on systems that have the "load upper/lower-unaligned" instructions. On others it's a memmove().