From: Christoph Hellwig <hch@infradead.org>
To: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] s390 (2/19): common i/o layer.
Date: Fri, 26 Sep 2003 09:02:04 +0100 [thread overview]
Message-ID: <20030926090204.A9195@infradead.org> (raw)
In-Reply-To: <20030925171542.GC2951@mschwid3.boeblingen.de.ibm.com>; from schwidefsky@de.ibm.com on Thu, Sep 25, 2003 at 07:15:42PM +0200
> +static inline void
> +__ccwgroup_remove_symlinks(struct ccwgroup_device *gdev)
> +{
> + int i;
> + char str[8];
> +
> + for (i = 0; i < gdev->count; i++) {
> + sprintf(str, "cdev%d", i);
> + sysfs_remove_link(&gdev->dev.kobj, str);
> + /* Hack: Make sure we act on still valid subdirs. */
> + if (atomic_read(&gdev->cdev[i]->dev.kobj.dentry->d_count))
> + sysfs_remove_link(&gdev->cdev[i]->dev.kobj,
> + "group_device");
> + }
This looks like you have a bad refcounting problem somewhere. I'd rather
see it fixed than hacked around..
next prev parent reply other threads:[~2003-09-26 8:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-25 17:15 [PATCH] s390 (2/19): common i/o layer Martin Schwidefsky
2003-09-26 8:02 ` Christoph Hellwig [this message]
2003-09-26 9:36 Martin Schwidefsky
2003-09-29 8:24 Martin Schwidefsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030926090204.A9195@infradead.org \
--to=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).