Re: Linux 2.6.0-test6

[Russell King <rmk@arm.linux.org.uk>]

On Sun, Sep 28, 2003 at 10:37:36AM -0700, Linus Torvalds wrote:
> On Sun, 28 Sep 2003, Geert Uytterhoeven wrote:
> > On Sat, 27 Sep 2003, Linus Torvalds wrote:
> > > Bernardo Innocenti:
> > >   o GCC 3.3.x/3.4 compatiblity fix in include/linux/init.h
> > 
> > This change breaks 2.95 for some source files, because <linux/init.h> doesn't
> > include <linux/compiler.h>. Do you want to have the missing include added to
> > <linux/init.h>, or to the individual source files that need it?
> 
> Interesting. I'm pretty sure I did a "make allyesconfig" just before the
> test6 release, so apparently x86 includes it indirectly through some path, 
> and so it only shows up on m68k and arm?
> 
> This, btw, is a pretty common thing. I wonder what we could do to make 
> sure that different architectures wouldn't have so different include file 
> structures. It's happened _way_ too often.
> 
> Any ideas?

The two files that it showed up in on ARM are fairly simple in nature and
don't include may headers.  Making the ARM include structure identical to
x86 wouldn't have removed the problem from ARM.

-- 
Russell King (rmk@arm.linux.org.uk)	http://www.arm.linux.org.uk/personal/
      Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
      maintainer of:  2.6 PCMCIA      - http://pcmcia.arm.linux.org.uk/
                      2.6 Serial core