From: Pavel Machek <pavel@suse.cz>
To: "Robert T. Johnson" <rtjohnso@eecs.berkeley.edu>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
scottm@somanetworks.com, greg@kroah.com, rgooch@atnf.csiro.au,
mingo@redhat.com, pavel@suse.cz
Subject: Re: 2.6.0-test6: a few __init bugs
Date: Tue, 30 Sep 2003 00:07:17 +0200 [thread overview]
Message-ID: <20030929220717.GH1815@elf.ucw.cz> (raw)
In-Reply-To: <1064872693.5733.42.camel@dooby.cs.berkeley.edu>
Hi!
> Here are several places where non-__init functions call __init functions
> or reference __init data. I've looked at all of them and believe that
> they are all either legitimate bugs or opportunities to declare more
> code as __init to save memory. Thanks for looking over these, and sorry
> if I've made any mistakes.
> ** Code should be declared __init?
> ** name_to_dev_t() (__init)
> called by kernel/power/swsusp.c:read_suspend_image() (not __init)
> called by kernel/power/swsusp.c:software_resume() (not __init)
> Fix: declare read_suspend_image() __init
> Fix: declare software_resume() __init
>
> Note: read_suspend_image() in pmdisk.c is declared __init.
Yes, it should be safe to declare that code __init. Applied.
Pavel
--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
next prev parent reply other threads:[~2003-09-29 22:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-29 21:58 2.6.0-test6: a few __init bugs Robert T. Johnson
2003-09-29 22:07 ` Pavel Machek [this message]
2003-09-29 22:11 ` Greg KH
[not found] ` <1064946634.5734.106.camel@dooby.cs.berkeley.edu>
[not found] ` <20030930191117.GA20054@kroah.com>
2003-09-30 21:20 ` Robert T. Johnson
2003-09-30 21:25 ` Greg KH
2003-09-30 21:42 ` Robert T. Johnson
2003-09-30 22:10 ` Greg KH
2003-10-01 21:26 ` bill davidsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030929220717.GH1815@elf.ucw.cz \
--to=pavel@suse.cz \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rgooch@atnf.csiro.au \
--cc=rtjohnso@eecs.berkeley.edu \
--cc=scottm@somanetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).