* scx200_wdt: Include linux/fs.h for struct file
@ 2003-10-22 11:20 Herbert Xu
2003-10-22 11:30 ` Herbert Xu
2003-10-22 11:34 ` Dave Jones
0 siblings, 2 replies; 3+ messages in thread
From: Herbert Xu @ 2003-10-22 11:20 UTC (permalink / raw)
To: Linus Torvalds, Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 393 bytes --]
Hi:
This patch adds an explicit inclusion of linux/fs.h as it needs to
dereference struct file *. This is needed for it to compile on
non-i386 architectures.
Cheers,
--
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
[-- Attachment #2: p --]
[-- Type: text/plain, Size: 633 bytes --]
Index: kernel-source-2.5/drivers/char/watchdog/scx200_wdt.c
===================================================================
RCS file: /home/gondolin/herbert/src/CVS/debian/kernel-source-2.5/drivers/char/watchdog/scx200_wdt.c,v
retrieving revision 1.1.1.3
diff -u -r1.1.1.3 scx200_wdt.c
--- kernel-source-2.5/drivers/char/watchdog/scx200_wdt.c 9 Aug 2003 08:11:55 -0000 1.1.1.3
+++ kernel-source-2.5/drivers/char/watchdog/scx200_wdt.c 22 Oct 2003 11:16:59 -0000
@@ -27,6 +27,7 @@
#include <linux/reboot.h>
#include <linux/pci.h>
#include <linux/scx200.h>
+#include <linux/fs.h>
#include <asm/uaccess.h>
#include <asm/io.h>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: scx200_wdt: Include linux/fs.h for struct file
2003-10-22 11:20 scx200_wdt: Include linux/fs.h for struct file Herbert Xu
@ 2003-10-22 11:30 ` Herbert Xu
2003-10-22 11:34 ` Dave Jones
1 sibling, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2003-10-22 11:30 UTC (permalink / raw)
To: Linus Torvalds, Linux Kernel Mailing List; +Cc: zwane
[-- Attachment #1: Type: text/plain, Size: 520 bytes --]
On Wed, Oct 22, 2003 at 09:20:35PM +1000, herbert wrote:
>
> This patch adds an explicit inclusion of linux/fs.h as it needs to
> dereference struct file *. This is needed for it to compile on
> non-i386 architectures.
The same change is needed on a number of other watchdog drivers.
Cheers,
--
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
[-- Attachment #2: p --]
[-- Type: text/plain, Size: 3842 bytes --]
Index: kernel-source-2.5/drivers/char/watchdog/alim1535_wdt.c
===================================================================
RCS file: /home/gondolin/herbert/src/CVS/debian/kernel-source-2.5/drivers/char/watchdog/alim1535_wdt.c,v
retrieving revision 1.1.1.2
diff -u -r1.1.1.2 alim1535_wdt.c
--- kernel-source-2.5/drivers/char/watchdog/alim1535_wdt.c 28 Sep 2003 04:44:12 -0000 1.1.1.2
+++ kernel-source-2.5/drivers/char/watchdog/alim1535_wdt.c 22 Oct 2003 11:26:00 -0000
@@ -17,6 +17,7 @@
#include <linux/reboot.h>
#include <linux/init.h>
#include <linux/pci.h>
+#include <linux/fs.h>
#include <asm/uaccess.h>
#include <asm/io.h>
Index: kernel-source-2.5/drivers/char/watchdog/alim7101_wdt.c
===================================================================
RCS file: /home/gondolin/herbert/src/CVS/debian/kernel-source-2.5/drivers/char/watchdog/alim7101_wdt.c,v
retrieving revision 1.1.1.5
diff -u -r1.1.1.5 alim7101_wdt.c
--- kernel-source-2.5/drivers/char/watchdog/alim7101_wdt.c 22 Aug 2003 23:58:10 -0000 1.1.1.5
+++ kernel-source-2.5/drivers/char/watchdog/alim7101_wdt.c 22 Oct 2003 11:24:43 -0000
@@ -25,6 +25,7 @@
#include <linux/reboot.h>
#include <linux/init.h>
#include <linux/pci.h>
+#include <linux/fs.h>
#include <asm/io.h>
#include <asm/uaccess.h>
Index: kernel-source-2.5/drivers/char/watchdog/amd7xx_tco.c
===================================================================
RCS file: /home/gondolin/herbert/src/CVS/debian/kernel-source-2.5/drivers/char/watchdog/amd7xx_tco.c,v
retrieving revision 1.1.1.5
diff -u -r1.1.1.5 amd7xx_tco.c
--- kernel-source-2.5/drivers/char/watchdog/amd7xx_tco.c 8 Oct 2003 19:24:02 -0000 1.1.1.5
+++ kernel-source-2.5/drivers/char/watchdog/amd7xx_tco.c 22 Oct 2003 11:28:27 -0000
@@ -31,6 +31,7 @@
#include <linux/reboot.h>
#include <linux/init.h>
#include <linux/pci.h>
+#include <linux/fs.h>
#define AMDTCO_MODULE_VER "build 20021116"
#define AMDTCO_MODULE_NAME "amd7xx_tco"
Index: kernel-source-2.5/drivers/char/watchdog/i810-tco.c
===================================================================
RCS file: /home/gondolin/herbert/src/CVS/debian/kernel-source-2.5/drivers/char/watchdog/i810-tco.c,v
retrieving revision 1.1.1.7
diff -u -r1.1.1.7 i810-tco.c
--- kernel-source-2.5/drivers/char/watchdog/i810-tco.c 28 Sep 2003 04:44:12 -0000 1.1.1.7
+++ kernel-source-2.5/drivers/char/watchdog/i810-tco.c 22 Oct 2003 11:22:44 -0000
@@ -56,6 +56,7 @@
#include <linux/init.h>
#include <linux/pci.h>
#include <linux/ioport.h>
+#include <linux/fs.h>
#include <asm/uaccess.h>
#include <asm/io.h>
#include "i810-tco.h"
Index: kernel-source-2.5/drivers/char/watchdog/sc1200wdt.c
===================================================================
RCS file: /home/gondolin/herbert/src/CVS/debian/kernel-source-2.5/drivers/char/watchdog/sc1200wdt.c,v
retrieving revision 1.1.1.3
diff -u -r1.1.1.3 sc1200wdt.c
--- kernel-source-2.5/drivers/char/watchdog/sc1200wdt.c 24 Feb 2003 19:05:11 -0000 1.1.1.3
+++ kernel-source-2.5/drivers/char/watchdog/sc1200wdt.c 22 Oct 2003 11:26:50 -0000
@@ -38,6 +38,7 @@
#include <linux/init.h>
#include <linux/pnp.h>
#include <linux/pci.h>
+#include <linux/fs.h>
#include <asm/semaphore.h>
#include <asm/io.h>
Index: kernel-source-2.5/drivers/char/watchdog/wdt_pci.c
===================================================================
RCS file: /home/gondolin/herbert/src/CVS/debian/kernel-source-2.5/drivers/char/watchdog/wdt_pci.c,v
retrieving revision 1.1.1.10
diff -u -r1.1.1.10 wdt_pci.c
--- kernel-source-2.5/drivers/char/watchdog/wdt_pci.c 28 Sep 2003 04:44:12 -0000 1.1.1.10
+++ kernel-source-2.5/drivers/char/watchdog/wdt_pci.c 22 Oct 2003 11:21:15 -0000
@@ -47,6 +47,7 @@
#include <linux/reboot.h>
#include <linux/init.h>
#include <linux/pci.h>
+#include <linux/fs.h>
#include <asm/io.h>
#include <asm/uaccess.h>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: scx200_wdt: Include linux/fs.h for struct file
2003-10-22 11:20 scx200_wdt: Include linux/fs.h for struct file Herbert Xu
2003-10-22 11:30 ` Herbert Xu
@ 2003-10-22 11:34 ` Dave Jones
1 sibling, 0 replies; 3+ messages in thread
From: Dave Jones @ 2003-10-22 11:34 UTC (permalink / raw)
To: Herbert Xu; +Cc: Linus Torvalds, Linux Kernel Mailing List
On Wed, Oct 22, 2003 at 09:20:35PM +1000, Herbert Xu wrote:
> This patch adds an explicit inclusion of linux/fs.h as it needs to
> dereference struct file *. This is needed for it to compile on
> non-i386 architectures.
A better question is why we're allowing Geode drivers to be compiled
on non-i386.
Dave
--
Dave Jones http://www.codemonkey.org.uk
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2003-10-22 11:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-10-22 11:20 scx200_wdt: Include linux/fs.h for struct file Herbert Xu
2003-10-22 11:30 ` Herbert Xu
2003-10-22 11:34 ` Dave Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).