linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Valdis.Kletnieks@vt.edu
To: mru@kth.se (Måns Rullgård)
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Autoregulate vm swappiness cleanup
Date: Tue, 28 Oct 2003 12:33:41 -0500	[thread overview]
Message-ID: <200310281733.h9SHXfxF028624@turing-police.cc.vt.edu> (raw)
In-Reply-To: Your message of "Tue, 28 Oct 2003 17:51:48 +0100." <yw1xy8v54863.fsf@kth.se>

[-- Attachment #1: Type: text/plain, Size: 1042 bytes --]

On Tue, 28 Oct 2003 17:51:48 +0100, mru@kth.se (=?iso-8859-1?q?M=E5ns_Rullg=E5rd?=)  said:

> Doing that mistake would give a linker error.

Not necessarily.  Consider shared libraries.  Load module1.so, load module2.so,
and then load module3.so that has an unresolved reference that both of the
other two happen to have. Oh wow.. results that are dependent on the order of
-l flags in a non-obvious way...  And '-z muldefs' is always a good way to
shoot yourself in the foot.....

Yes, it's stupid, yes, it's a mistake - my point is that the design of C makes that
sort of mistake more likely.  If there *did* exist a "private to all the pieces of the
module" status similar to the "private to THIS .c 'static'", it wouldn't be anywhere
near the problem.

And don't tell me that the Linux kernel hasn't seen similar issues - a supposedly
private interface that didn't have 'static' because it *was* called from 2 other
.c files in the directory.  And then we have to tell people "don't call that interface,
it's private".

[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]

  reply	other threads:[~2003-10-28 17:33 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-10-28 13:34 [PATCH] Autoregulate vm swappiness cleanup Boszormenyi Zoltan
2003-10-28 14:39 ` Richard B. Johnson
2003-10-28 15:39   ` Valdis.Kletnieks
2003-10-28 15:54     ` Richard B. Johnson
2003-10-28 16:37       ` Valdis.Kletnieks
2003-10-28 16:51         ` Måns Rullgård
2003-10-28 17:33           ` Valdis.Kletnieks [this message]
2003-11-03  8:15   ` [OT] " Boszormenyi Zoltan
  -- strict thread matches above, loose matches on Subject: below --
2003-10-23 13:37 [PATCH] Autoregulate vm swappiness 2.6.0-test8 Con Kolivas
2003-10-23 14:42 ` Martin J. Bligh
2003-10-23 15:03   ` Con Kolivas
2003-10-25  6:58     ` [PATCH] Autoregulate vm swappiness cleanup Con Kolivas
2003-10-26 11:22       ` Nick Piggin
2003-10-26 10:36         ` Con Kolivas
2003-10-26 11:42           ` Nick Piggin
2003-10-28 11:04       ` Pavel Machek
2003-10-28 12:40         ` Con Kolivas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200310281733.h9SHXfxF028624@turing-police.cc.vt.edu \
    --to=valdis.kletnieks@vt.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mru@kth.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).