From: Greg KH <greg@kroah.com>
To: Andreas Schwab <schwab@suse.de>,
Linux Kernel List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Prevent PCI driver registration failure oopsing
Date: Wed, 29 Oct 2003 15:30:42 -0800 [thread overview]
Message-ID: <20031029233042.GB1707@kroah.com> (raw)
In-Reply-To: <20031028105126.I22424@flint.arm.linux.org.uk>
On Tue, Oct 28, 2003 at 10:51:26AM +0000, Russell King wrote:
> On Tue, Oct 28, 2003 at 11:48:05AM +0100, Andreas Schwab wrote:
> > Russell King <rmk+lkml@arm.linux.org.uk> writes:
> > > + return rc < 0 ? : 0;
> >
> > Are you sure you want to return 1 if rc < 0?
>
> Argh. Definitely not. Thanks for spotting that.
>
> --- orig/include/linux/pci.h Thu Mar 13 14:24:56 2003
> +++ linux/include/linux/pci.h Wed Mar 12 19:37:41 2003
Thanks, I've applied this and will send it to Linus when 2.6.0 is out.
greg k-h
prev parent reply other threads:[~2003-10-29 23:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-28 10:04 [PATCH] Prevent PCI driver registration failure oopsing Russell King
2003-10-28 10:48 ` Andreas Schwab
2003-10-28 10:51 ` Russell King
2003-10-29 23:30 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031029233042.GB1707@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).