From: "David S. Miller" <davem@redhat.com>
To: devik <devik@cdi.cz>
Cc: daniel.blueman@gmx.net, netdev@oss.sgi.com,
linux-net@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [2.6.0-test9] QoS HTB crash...
Date: Thu, 30 Oct 2003 13:08:59 -0800 [thread overview]
Message-ID: <20031030130859.605f856d.davem@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.33.0310302047440.11221-100000@devix>
On Thu, 30 Oct 2003 20:50:16 +0100 (CET)
devik <devik@cdi.cz> wrote:
> thanks for the report. I know that there is an issue regarding
> HTB in 2.6.x. Please send me net/sched/sch_htb.o,
> net/sched/sch_htb.c (just to be sure) and be sure that you
> build the kernel with debugging symbols (see debugging section
> of menuconfig/xconfig).
I think the problem is the changes that were made
in 2.5.x to htb_next_rb_node(). It used to be:
static void htb_next_rb_node(rb_node_t **n)
{
rb_node_t *p;
if ((*n)->rb_right) {
/* child at right. use it or its leftmost ancestor */
*n = (*n)->rb_right;
while ((*n)->rb_left)
*n = (*n)->rb_left;
return;
}
while ((p = (*n)->rb_parent) != NULL) {
/* if we've arrived from left child then we have next node */
if (p->rb_left == *n) break;
*n = p;
}
*n = p;
}
But it was changed into:
static void htb_next_rb_node(struct rb_node **n)
{
*n = rb_next(*n);
}
This is wrong, the new code has much different side effects
than the original code.
This looks like the problem, devik what do you think?
next prev parent reply other threads:[~2003-10-30 21:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-30 16:10 [2.6.0-test9] QoS HTB crash Daniel Blueman
2003-10-30 19:50 ` devik
2003-10-30 21:08 ` David S. Miller [this message]
2003-10-31 7:40 ` devik
2003-11-01 18:13 ` Daniel Blueman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031030130859.605f856d.davem@redhat.com \
--to=davem@redhat.com \
--cc=daniel.blueman@gmx.net \
--cc=devik@cdi.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net@vger.kernel.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).