linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@debian.org>
To: "Noah J. Misch" <noah@caltech.edu>
Cc: Matthew Wilcox <willy@debian.org>,
	linux-ia64@linuxia64.org, acpi-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org
Subject: Re: [ACPI] [PATCH][RFC] Clean up Kconfig logic for IA64 ACPI
Date: Sun, 2 Nov 2003 04:34:02 +0000	[thread overview]
Message-ID: <20031102043402.GF3824@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <Pine.GSO.4.58.0311011945190.18996@sue>

On Sat, Nov 01, 2003 at 08:05:44PM -0800, Noah J. Misch wrote:
> I do not read linux-ia64 regularly, so I did not notice your work.  I
> apologize for not acknowledging it.

No problem ;-)

> Why not include drivers/Kconfig and scrap the individual subdirectory
> includes, as i386 does?

At that time, I hadn't done the work to create drivers/Kconfig ;-)
The main problem for ia64 is the simulator stuff.  Maybe something like:

if !IA64_HP_SIM
source "drivers/Kconfig"
endif

if IA64_HP_SIM
source "drivers/base/Kconfig"
source "drivers/scsi/Kconfig"
source "net/Kconfig"
source "drivers/block/Kconfig"
source "arch/ia64/hp/sim/Kconfig"
endif

(I guess Kconfig needs an "else" keyword).

(Also the duplication of drivers/block/Kconfig is no longer necessary).

> Also, it looks like your patch makes ACPI non-mandatory.  Is that intentional?

Hmmm... no ;-)  I agree the "select" should probably go in -- we seem
to be infected with ACPI for the foreseeable future ;-(

I imagine these kinds of patches can go into 2.6.1 -- the freeze should
let up a bit by then.

-- 
"It's not Hollywood.  War is real, war is primarily not about defeat or
victory, it is about death.  I've seen thousands and thousands of dead bodies.
Do you think I want to have an academic debate on this subject?" -- Robert Fisk

  reply	other threads:[~2003-11-02  4:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-11-02  0:35 [PATCH][RFC] Clean up Kconfig logic for IA64 ACPI Noah J. Misch
2003-11-02  3:16 ` [ACPI] " Matthew Wilcox
2003-11-02  4:05   ` Noah J. Misch
2003-11-02  4:34     ` Matthew Wilcox [this message]
2003-11-02  6:41       ` IA64/simulators - Kconfig logic for drivers/* Noah J. Misch
2003-11-03 21:55         ` David Mosberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031102043402.GF3824@parcelfarce.linux.theplanet.co.uk \
    --to=willy@debian.org \
    --cc=acpi-devel@lists.sourceforge.net \
    --cc=linux-ia64@linuxia64.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=noah@caltech.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).