From: Kronos <kronos@kronoz.cjb.net>
To: linux-kernel@vger.kernel.org
Cc: Geoffrey Lee <glee@gnupilgrims.org>, Dave Jones <davej@redhat.com>
Subject: Re: [patch] reproducible athlon mce fix
Date: Sun, 2 Nov 2003 19:25:56 +0100 [thread overview]
Message-ID: <20031102182556.GA4974@dreamland.darkstar.lan> (raw)
In-Reply-To: <20031102055748.GA1218@anakin.wychk.org>
Geoffrey Lee ha scritto:
> After switching from 2.4.22 to 2.6.0-test9, I have received reproducible
> MCE non-fatal error check messages in my kernel log. (For example, one
> shows up right after my first scsi card init).
[cut]
> would seem to imply that Athlons don't like having their Bank 0 poked at,
> though that's what non-fatal.c does. Would it be correct to make sure
> that that non-fatal.c starts at bank 1, if it is an Athlon?
>
> --- linux-2.6.0-test9/arch/i386/kernel/cpu/mcheck/non-fatal.c.orig 2003-11-02 13:31:43.000000000 +0800
> +++ linux-2.6.0-test9/arch/i386/kernel/cpu/mcheck/non-fatal.c 2003-11-02 13:34:37.000000000 +0800
> @@ -30,7 +30,11 @@
> int i;
>
> preempt_disable();
> +#if CONFIG_MK7
> + for (i=1; i<nr_mce_banks; i++) {
> +#else
> for (i=0; i<nr_mce_banks; i++) {
> +#endif
> rdmsr (MSR_IA32_MC0_STATUS+i*4, low, high);
>
> if (high & (1<<31)) {
In this way you don't read from bank 0. The strange thing is that
amd_mcheck_init doesn't enable reporting on this bank... it should stay
clean. What's going on here?
Luca
--
Reply-To: kronos@kronoz.cjb.net
Home: http://kronoz.cjb.net
Quando un uomo porta dei fiori a sua moglie senza motivo,
un motivo c'e`.
next prev parent reply other threads:[~2003-11-02 19:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-02 5:57 [patch] reproducible athlon mce fix Geoffrey Lee
2003-11-02 7:25 ` Willy Tarreau
2003-11-02 7:28 ` Geoffrey Lee
2003-11-02 8:59 ` Zwane Mwaikambo
2003-11-10 23:55 ` bill davidsen
2003-11-02 12:52 ` Dave Jones
2003-11-02 13:52 ` Geoffrey Lee
2003-11-03 9:20 ` Geoffrey Lee
2003-11-03 13:24 ` Dave Jones
2003-11-02 18:25 ` Kronos [this message]
2003-11-02 23:44 ` Geoffrey Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031102182556.GA4974@dreamland.darkstar.lan \
--to=kronos@kronoz.cjb.net \
--cc=davej@redhat.com \
--cc=glee@gnupilgrims.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).