From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263747AbTKFULI (ORCPT ); Thu, 6 Nov 2003 15:11:08 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263792AbTKFULI (ORCPT ); Thu, 6 Nov 2003 15:11:08 -0500 Received: from pizda.ninka.net ([216.101.162.242]:30633 "EHLO pizda.ninka.net") by vger.kernel.org with ESMTP id S263747AbTKFULE (ORCPT ); Thu, 6 Nov 2003 15:11:04 -0500 Date: Thu, 6 Nov 2003 12:05:48 -0800 From: "David S. Miller" To: azarah@gentoo.org Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] 2.4.21-rc1: byteorder.h breaks with __STRICT_ANSI__ defined (trivial) Message-Id: <20031106120548.097ccc7c.davem@redhat.com> In-Reply-To: <1068149368.12287.331.camel@nosferatu.lan> References: <1068140199.12287.246.camel@nosferatu.lan> <20031106093746.5cc8066e.davem@redhat.com> <1068143563.12287.264.camel@nosferatu.lan> <1068144179.12287.283.camel@nosferatu.lan> <20031106113716.7382e5d2.davem@redhat.com> <1068149368.12287.331.camel@nosferatu.lan> X-Mailer: Sylpheed version 0.9.7 (GTK+ 1.2.6; sparc-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 06 Nov 2003 22:09:29 +0200 Martin Schlemmer wrote: > On Thu, 2003-11-06 at 21:37, David S. Miller wrote: > > Let's say that you end up using some inline function > > that takes u32 arguments, and internally it uses > > u64 types to speed up the calculation or make it more > > accurate or something like that. > > So basically only in cases where the stuff in byteorder.h > was not inlined ... ? No, exactly in the cases where it _IS_ inlined. Imagine this: static inline u32 swab_foo(u32 a, u32 b) { u64 tmp = ((u64)a<<32) | ((u64)b); u32 retval; retval = compute(tmp); return retval; } If that's in a kernel header somewhere, and you build with -ansi, you lose.