From: Matt Mackall <mpm@selenic.com>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Zwane Mwaikambo <zwane@arm.linux.org.uk>,
Ingo Molnar <mingo@elte.hu>,
"Martin J. Bligh" <mbligh@aracnet.com>,
Andrew Morton <akpm@osdl.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org, Hugh Dickins <hugh@veritas.com>
Subject: Re: [PATCH][2.6-mm] Fix 4G/4G X11/vm86 oops
Date: Thu, 20 Nov 2003 01:44:05 -0600 [thread overview]
Message-ID: <20031120074405.GG22139@waste.org> (raw)
In-Reply-To: <20031119230928.GE22139@waste.org>
On Wed, Nov 19, 2003 at 05:09:28PM -0600, Matt Mackall wrote:
> On Wed, Nov 19, 2003 at 02:32:10PM -0600, Matt Mackall wrote:
> >
> > Zwane's got a K6-2 500MHz. I've just managed to reproduce this on my
> > 1.4GHz Opteron box (with Debian gcc 3.2). Here, the "ooh la la" bit
> > doesn't help. So my suspicion is that the printk is changing the
> > timing just enough on Zwane's box that he's getting a timer interrupt
> > knocking him out of vm86 mode before he hits a fatal bit in the fault
> > handling path for 4/4. Printks in handle_vm86_trap, handle_vm86_fault,
> > do_trap:vm86_trap, and do_general_protection:gp_in_vm86 never fire so
> > there's probably something amiss in the trampoline code.
>
> Some more datapoints:
>
> CPU distro compiler video X result
> K6-2/500 connectiva 9 2.96 trident 4.3 reboot (zwane)
> K6-2/500 connectiva 9 3.2.2 trident 4.3 reboot (zwane)
> Opteron 240 debian unstable 3.2 S3 4.2.1 reboot
> Athlon 2100 debian unstable 3.2 radeon 7500 4.2.1 works
> P4M 1800 debian unstable 3.2 radeon m7 4.2.1 reboot
And indeed it does turn out to be a problem with the trampoline
mechanics. The fix for -mm4:
Fix triple faulting on some boxes with 4G/4G
mm-mpm/arch/i386/kernel/vm86.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
diff -puN arch/i386/kernel/vm86.c~virtual-esp arch/i386/kernel/vm86.c
--- mm/arch/i386/kernel/vm86.c~virtual-esp 2003-11-20 01:36:32.000000000 -0600
+++ mm-mpm/arch/i386/kernel/vm86.c 2003-11-20 01:36:32.000000000 -0600
@@ -306,7 +306,7 @@ static void do_sys_vm86(struct kernel_vm
tss->esp0 = virtual_esp0(tsk);
if (cpu_has_sep)
tsk->thread.sysenter_cs = 0;
- load_esp0(tss, &tsk->thread);
+ load_virtual_esp0(tss, tsk);
put_cpu();
tsk->thread.screen_bitmap = info->screen_bitmap;
_
--
Matt Mackall : http://www.selenic.com : Linux development and consulting
next prev parent reply other threads:[~2003-11-20 7:44 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-13 7:30 2.6.0-test9-mm3 Andrew Morton
2003-11-13 20:03 ` [PATCH] linux-2.6.0-test9-mm3_verbose-timesource-acpi-pm_A0 john stultz
2003-11-13 22:03 ` 2.6.0-test9-mm3 - AIO test results Daniel McNeil
2003-11-17 5:25 ` Suparna Bhattacharya
2003-11-18 1:15 ` Daniel McNeil
2003-11-18 1:37 ` Daniel McNeil
2003-11-18 11:55 ` Suparna Bhattacharya
2003-11-18 23:47 ` Daniel McNeil
2003-11-24 9:42 ` Suparna Bhattacharya
2003-11-25 23:49 ` [PATCH 2.6.0-test9-mm5] aio-dio-fallback-bio_count-race.patch Daniel McNeil
2003-11-26 7:55 ` Suparna Bhattacharya
2003-12-02 1:35 ` Daniel McNeil
2003-12-02 15:25 ` Suparna Bhattacharya
2003-12-03 23:14 ` Daniel McNeil
2003-12-04 4:40 ` Suparna Bhattacharya
2003-11-13 22:04 ` 2.6.0-test9-mm3 (compile stats) John Cherry
2003-11-14 5:07 ` 2.6.0-test9-mm3 Martin J. Bligh
2003-11-14 20:57 ` 2.6.0-test9-mm3 Zwane Mwaikambo
2003-11-14 21:57 ` 2.6.0-test9-mm3 Martin J. Bligh
2003-11-14 21:37 ` 2.6.0-test9-mm3 Zwane Mwaikambo
2003-11-14 21:47 ` 2.6.0-test9-mm3 Linus Torvalds
2003-11-15 0:55 ` 2.6.0-test9-mm3 Zwane Mwaikambo
2003-11-15 19:34 ` [PATCH][2.6-mm] Fix 4G/4G X11/vm86 oops Zwane Mwaikambo
2003-11-15 19:52 ` Zwane Mwaikambo
2003-11-17 21:46 ` Zwane Mwaikambo
2003-11-17 22:42 ` Linus Torvalds
2003-11-17 23:01 ` Zwane Mwaikambo
2003-11-17 23:14 ` Zwane Mwaikambo
2003-11-18 7:21 ` Zwane Mwaikambo
2003-11-18 15:47 ` Linus Torvalds
2003-11-18 16:16 ` Zwane Mwaikambo
2003-11-18 16:37 ` Linus Torvalds
2003-11-18 17:08 ` Zwane Mwaikambo
2003-11-18 17:38 ` Martin J. Bligh
2003-11-18 17:22 ` Zwane Mwaikambo
2003-11-19 20:32 ` Matt Mackall
2003-11-19 23:09 ` Matt Mackall
2003-11-20 7:14 ` Zwane Mwaikambo
2003-11-20 7:44 ` Matt Mackall [this message]
2003-11-20 7:53 ` Andrew Morton
2003-11-20 8:13 ` Matt Mackall
2003-11-14 19:08 ` 2.6.0-test9-mm3 Martin J. Bligh
2003-11-14 18:59 ` 2.6.0-test9-mm3 Andrew Morton
2003-11-14 19:32 ` 2.6.0-test9-mm3 Mike Fedyk
2003-11-14 20:27 ` 2.6.0-test9-mm3 John Stoffel
2003-11-15 1:01 ` 2.6.0-test9-mm3 Mike Fedyk
2003-11-14 19:10 ` 2.6.0-test9-mm3 Badari Pulavarty
2003-11-14 20:29 ` 2.6.0-test9-mm3 Martin J. Bligh
2003-11-17 20:58 ` 2.6.0-test9-mm3 bill davidsen
2003-11-18 23:48 Re:Re: [PATCH][2.6-mm] Fix 4G/4G X11/vm86 oops Jon Foster
2003-11-19 3:24 ` Zwane Mwaikambo
2003-11-19 5:45 ` Andrew Morton
2003-11-19 6:50 ` Zwane Mwaikambo
2003-11-19 7:24 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031120074405.GG22139@waste.org \
--to=mpm@selenic.com \
--cc=akpm@osdl.org \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mbligh@aracnet.com \
--cc=mingo@elte.hu \
--cc=torvalds@osdl.org \
--cc=zwane@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).