From: "YOSHIFUJI Hideaki / 吉藤英明" <yoshfuji@linux-ipv6.org>
To: rmk+lkml@arm.linux.org.uk
Cc: felipe_alfaro@linuxmail.org, davem@redhat.com,
linux-kernel@vger.kernel.org, netdev@oss.sgi.com,
yoshfuji@linux-ipv6.org
Subject: Re: [PATCH 2.6]: IPv6: strcpy -> strlcpy
Date: Fri, 28 Nov 2003 04:54:13 +0900 (JST) [thread overview]
Message-ID: <20031128.045413.133305490.yoshfuji@linux-ipv6.org> (raw)
In-Reply-To: <20031127194602.A25015@flint.arm.linux.org.uk>
In article <20031127194602.A25015@flint.arm.linux.org.uk> (at Thu, 27 Nov 2003 19:46:02 +0000), Russell King <rmk+lkml@arm.linux.org.uk> says:
> > > > I agree, using sizeof() is the less error prone way of
> > > > doing things like this.
> > > >
> > > > Felipe could you please rewrite your patch like this?
> > >
> > > Done!
> >
> > Thanks. Ok to me.
>
> I'm slightly cautious here, although I haven't read the patch yet.
> Did anyone consider whether any of these structures were copied to
> user space, and whether, as a result of this change, we're now
> copying uninitialised data to users?
I believe that it, to change from strcpy() to strlcpy(), just
eliminates possibility of buffer-overrun.
--yoshfuji
next prev parent reply other threads:[~2003-11-27 19:54 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-27 8:14 [PATCH 2.6]: IPv6: strcpy -> strlcpy Felipe Alfaro Solana
2003-11-27 8:33 ` YOSHIFUJI Hideaki / 吉藤英明
2003-11-27 10:59 ` David S. Miller
2003-11-27 12:04 ` Felipe Alfaro Solana
2003-11-27 12:09 ` YOSHIFUJI Hideaki / 吉藤英明
2003-11-27 19:46 ` Russell King
2003-11-27 19:54 ` YOSHIFUJI Hideaki / 吉藤英明 [this message]
2003-11-27 20:00 ` Russell King
2003-11-27 20:47 ` YOSHIFUJI Hideaki / 吉藤英明
2003-11-27 21:14 ` Murray J. Root
2003-11-27 22:06 ` Felipe Alfaro Solana
2003-11-27 22:19 ` Russell King
2003-11-27 22:33 ` Russell King
2003-11-28 1:34 ` Mitchell Blank Jr
2003-11-27 23:03 ` Felipe Alfaro Solana
2003-11-28 0:23 ` YOSHIFUJI Hideaki / 吉藤英明
2003-11-28 0:26 ` YOSHIFUJI Hideaki / 吉藤英明
2003-11-28 0:40 ` YOSHIFUJI Hideaki / 吉藤英明
2003-11-28 11:22 ` Jörn Engel
[not found] <Wt8p.1R5.13@gated-at.bofh.it>
[not found] ` <Wti7.2fc.19@gated-at.bofh.it>
[not found] ` <WAjQ.83K.37@gated-at.bofh.it>
[not found] ` <WAte.8iX.5@gated-at.bofh.it>
[not found] ` <WACW.a9.19@gated-at.bofh.it>
[not found] ` <WCuZ.2Tm.11@gated-at.bofh.it>
[not found] ` <WCOd.3u0.1@gated-at.bofh.it>
2003-11-28 14:04 ` Ihar 'Philips' Filipau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031128.045413.133305490.yoshfuji@linux-ipv6.org \
--to=yoshfuji@linux-ipv6.org \
--cc=davem@redhat.com \
--cc=felipe_alfaro@linuxmail.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=rmk+lkml@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).