linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@suse.de>
To: Pavel Machek <pavel@ucw.cz>
Cc: "Prakash K. Cheemplavam" <prakashpublic@gmx.de>,
	kernel list <linux-kernel@vger.kernel.org>,
	jgarzik@pobox.com
Subject: Re: FYI: My current suspend bigdiff
Date: Sun, 30 Nov 2003 18:21:34 +0100	[thread overview]
Message-ID: <20031130172134.GB10679@suse.de> (raw)
In-Reply-To: <20031130171833.GB516@elf.ucw.cz>

On Sun, Nov 30 2003, Pavel Machek wrote:
> Hi!
> 
> > >Well... it could work with scsi. You can try it, but be carefull. [If
> > >it goes wrong it might eat your data.]
> > 
> > Thats why I use xfs on my main system to test... And I tried with libata 
> > and it won't work as it complains that the "katad" process cannot be 
> > stopped, so swsusp immediatly comes back.
> 
> I do not know how much more support is needed to allow powermanagment
> for libata, but this one should be easy...
> 
> [Hmm, I hope it compiles, I certainly do not use libata for now.]
> 								Pavel
> 
> --- clean/drivers/scsi/libata-core.c	2003-11-28 17:06:39.000000000 +0100
> +++ linux/drivers/scsi/libata-core.c	2003-11-30 18:16:02.000000000 +0100
> @@ -34,6 +34,7 @@
>  #include <linux/delay.h>
>  #include <linux/timer.h>
>  #include <linux/interrupt.h>
> +#include <linux/suspend.h>
>  #include <scsi/scsi.h>
>  #include "scsi.h"
>  #include "hosts.h"
> @@ -2564,6 +2565,8 @@
>  
>          while (1) {
>  		cond_resched();
> +		if (current->flags & PF_FREEZE)
> +			refrigerator(PF_IOTHREAD);

Curious - can't this be put some place a bit smarter, so we don't have
to update every single "driver" with a kernel thread out there (like in
the scheduler)? Seems pretty fragile to rely on this. Plus, when you
change this in the future there'll be N drivers to update again.

-- 
Jens Axboe


  reply	other threads:[~2003-11-30 17:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20031128171323.GG303@elf.ucw.cz>
     [not found] ` <3FC7860C.2060505@gmx.de>
     [not found]   ` <20031128173312.GH303@elf.ucw.cz>
     [not found]     ` <3FC789F5.2000208@gmx.de>
     [not found]       ` <20031128175503.GB18072@elf.ucw.cz>
     [not found]         ` <3FC7908A.9030007@gmx.de>
     [not found]           ` <20031128235623.GB18147@elf.ucw.cz>
     [not found]             ` <3FC8C0DB.9050107@gmx.de>
     [not found]               ` <20031129172537.GB459@elf.ucw.cz>
     [not found]                 ` <3FC9C560.2070902@gmx.de>
2003-11-30 17:18                   ` FYI: My current suspend bigdiff Pavel Machek
2003-11-30 17:21                     ` Jens Axboe [this message]
2003-11-30 17:24                       ` Jeff Garzik
2003-11-30 17:22                     ` Prakash K. Cheemplavam
2003-11-30 17:25                       ` Jeff Garzik
2003-11-30 17:35                         ` Pavel Machek
2003-12-01  0:09                         ` Benjamin Herrenschmidt
2003-11-24 11:07 Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031130172134.GB10679@suse.de \
    --to=axboe@suse.de \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=prakashpublic@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).