From: Masatake YAMATO <jet@gyve.org>
To: linux-kernel@vger.kernel.org
Cc: oliver@neukum.org
Subject: hfs on scsi device
Date: Tue, 02 Dec 2003 22:26:29 +0900 (JST) [thread overview]
Message-ID: <20031202.222629.24608383.jet@gyve.org> (raw)
Hi,
2.4.23 kernel shows oops when I've tried to mount hfs file system
on a CDROM in scsi CDROM drive. (Strictly speaking I'm using ide-scsi
kernel parameter.) I inspect this issue.
This issue was reported and discussed this April:
http://www.ussg.iu.edu/hypermail/linux/kernel/0304.0/0365.html
http://marc.theaimsgroup.com/?l=linux-kernel&m=102890250915062&w=2
The symptom of oops is appeared in dmesg:
kernel BUG at buffer.c:2518!
...
The line is in grow_buffers() function:
/* Size must be multiple of hard sectorsize */
if (size & (get_hardsect_size(dev)-1))
BUG();
It seems that setting the block size is failed before the control reaches
this line.
With the following patch for linux-2.4.23/fs/hfs/super.c, you can avoid
the oops. The patch just checks the return value from set_blocksize.
If set_blocksize is failed, just return from the function(hfs_read_super).
Masatake YAMATO
jet@gyve.org
397a398
> int dev_blocksize;
409c410,415
< set_blocksize(dev, HFS_SECTOR_SIZE);
---
> if (set_blocksize(dev, HFS_SECTOR_SIZE) < 0) {
> dev_blocksize = get_hardsect_size(dev);
> hfs_warn("hfs_fs: unsupported device block size: %d\n",
> dev_blocksize);
> goto bail3;
> }
reply other threads:[~2003-12-02 13:26 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031202.222629.24608383.jet@gyve.org \
--to=jet@gyve.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oliver@neukum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).