archive mirror
 help / color / mirror / Atom feed
* hfs on scsi device
@ 2003-12-02 13:26 Masatake YAMATO
  0 siblings, 0 replies; only message in thread
From: Masatake YAMATO @ 2003-12-02 13:26 UTC (permalink / raw)
  To: linux-kernel; +Cc: oliver


2.4.23 kernel shows oops when I've tried to mount hfs file system
on a CDROM in scsi CDROM drive. (Strictly speaking I'm using ide-scsi
kernel parameter.) I inspect this issue. 

This issue was reported and discussed this April:

The symptom of oops is appeared in dmesg:

    kernel BUG at buffer.c:2518!

The line is in grow_buffers() function:

	/* Size must be multiple of hard sectorsize */
	if (size & (get_hardsect_size(dev)-1))

It seems that setting the block size is failed before the control reaches
this line.

With the following patch for linux-2.4.23/fs/hfs/super.c, you can avoid
the oops. The patch just checks the return value from set_blocksize.
If set_blocksize is failed, just return from the function(hfs_read_super). 

Masatake YAMATO

> 	int dev_blocksize;
< 	set_blocksize(dev, HFS_SECTOR_SIZE);
> 	if (set_blocksize(dev, HFS_SECTOR_SIZE) < 0) {
> 		dev_blocksize = get_hardsect_size(dev);
> 		hfs_warn("hfs_fs: unsupported device block size: %d\n",
> 			 dev_blocksize);
> 		goto bail3;
> 	}

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2003-12-02 13:26 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-12-02 13:26 hfs on scsi device Masatake YAMATO

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).