* Laptop mode and 2.4.23
@ 2003-12-02 7:14 Michael Frank
0 siblings, 0 replies; only message in thread
From: Michael Frank @ 2003-12-02 7:14 UTC (permalink / raw)
To: axboe; +Cc: linux-kernel
Using laptop mode for the first time. Kernel is 2.4.23-Vanilla+kdb4.3 on a x86 notebook.
IDE Disk is ext3 mounted with rw,noatime
# cat /proc/sys/vm/laptop_mode
1
# cat /proc/sys/vm/bdflush
30 500 0 0 60000 60000 60 20 0
- Any disk write access spins up and writes as usual after 5 seconds by kjournald
- A disk spinup by kjournald does _not_ run bdflush and kupdated, so once they
elapse, the disk spins up again
This part of the laptop-mode patch is missing and the 5 second interval is still hardcoded:
diff -Nru a/fs/jbd/transaction.c b/fs/jbd/transaction.c
--- a/fs/jbd/transaction.cWed May 14 11:29:52 2003
+++ b/fs/jbd/transaction.cWed May 14 11:29:52 2003
@@ -56,7 +56,11 @@
transaction->t_journal = journal;
transaction->t_state = T_RUNNING;
transaction->t_tid = journal->j_transaction_sequence++;
-transaction->t_expires = jiffies + journal->j_commit_interval;
+/*
+ * have to do it here, otherwise changed age_buffers since boot
+ * wont have any effect
+ */
+transaction->t_expires = jiffies + get_buffer_flushtime();
INIT_LIST_HEAD(&transaction->t_jcb);
IMHO, without this patch, laptop-mode is only half as useful ;)
Why was this part of the patch not used?
Regards
Michael
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2003-12-02 7:14 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-12-02 7:14 Laptop mode and 2.4.23 Michael Frank
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).