linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christian Borntraeger <kernel@borntraeger.net>
To: ajbezerra@ufam.edu.br, linux-kernel@vger.kernel.org
Cc: linux-mm@vger.kernel.org, riel@nl.linux.org
Subject: Re: [PATCH 2.6.0] Resident memory info in fs/proc/task_mmu.c
Date: Tue, 2 Dec 2003 16:50:19 +0100	[thread overview]
Message-ID: <200312021650.20036.kernel@borntraeger.net> (raw)
In-Reply-To: <18562.200.212.156.130.1070375149.squirrel@webmail.ufam.edu.br>

ajbezerra@ufam.edu.br wrote:
> Hi everyone,
>
> Here is a suggestion for a patch of fs/proc/task_mm.c which gives
> more information about resident memory allocation for a given
> process PID at /proc/PID/status.
> -       unsigned long data = 0, stack = 0, exec = 0, lib = 0;
> -       struct vm_area_struct *vma;
> -
> -       down_read(&mm->mmap_sem);
> -       for (vma = mm->mmap; vma; vma = vma->vm_next) {
[...]
> +  unsigned long data = 0, stack = 0, exec = 0, lib = 0;
[...]
> +  struct vm_area_struct *vma;
> +  down_read(&mm->mmap_sem);
[...]

and so on.

Why are you breaking the Coding style? Can you keep the standard indentation 
please? This will make your patch much smaller and easier to see what you 
actually changed.

cheers

Christian


      reply	other threads:[~2003-12-02 15:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-12-02 14:25 [PATCH 2.6.0] Resident memory info in fs/proc/task_mmu.c ajbezerra
2003-12-02 15:50 ` Christian Borntraeger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200312021650.20036.kernel@borntraeger.net \
    --to=kernel@borntraeger.net \
    --cc=ajbezerra@ufam.edu.br \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@vger.kernel.org \
    --cc=riel@nl.linux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).