From: Matt Domsch <Matt_Domsch@dell.com>
To: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
Cc: Anton Altaparmakov <aia21@cam.ac.uk>,
Meelis Roos <mroos@linux.ee>,
linux-kernel@vger.kernel.org
Subject: Re: 2.4.23-bk bogus edd changeset - Re: 2.4.23 compile error in edd
Date: Fri, 5 Dec 2003 11:36:19 -0600 [thread overview]
Message-ID: <20031205113619.A20371@lists.us.dell.com> (raw)
In-Reply-To: <Pine.LNX.4.44.0312051109580.1782-100000@logos.cnet>; from marcelo.tosatti@cyclades.com on Fri, Dec 05, 2003 at 01:52:42PM -0200
> On Thu, 4 Dec 2003, Anton Altaparmakov wrote:
> > 2.4.23-bk has a changeset (post 2.4.23 release TAG) that makes edd not
> > compile as Meelis Roos already reported:
> > > DISKSIG_BUFFER is nowhere to be seen.
Yeah, that's my bad, setup.c should say DISK80_SIG_BUFFER not
DISKSIG_BUFFER.
===== arch/i386/kernel/setup.c 1.77 vs edited =====
--- 1.77/arch/i386/kernel/setup.c Mon Dec 1 09:23:55 2003
+++ edited/arch/i386/kernel/setup.c Fri Dec 5 10:58:11 2003
@@ -211,7 +211,7 @@
#define KERNEL_START (*(unsigned long *) (PARAM+0x214))
#define INITRD_START (*(unsigned long *) (PARAM+0x218))
#define INITRD_SIZE (*(unsigned long *) (PARAM+0x21c))
-#define DISK80_SIGNATURE_BUFFER (*(unsigned int*)(PARAM+DISKSIG_BUFFER))
+#define DISK80_SIGNATURE_BUFFER (*(unsigned int*)(PARAM+DISK80_SIG_BUFFER))
#define EDD_NR (*(unsigned char *) (PARAM+EDDNR))
#define EDD_BUF ((struct edd_info *) (PARAM+EDDBUF))
#define COMMAND_LINE ((char *) (PARAM+2048))
With this, it works for me on my PowerEdge 4600 with disks on the
aic7xxx, and the same int13 code works on all other PowerEdge servers
we've ever tried it on. What kind of system and disks (IDE/SCSI) and
BIOS do you have for those please?
> > However, changing DISKSIG_BUFFER to DISK80_SIG_BUFFER causes the kernel to
> > reboot the computer as soon as it starts booting. Basically I select it
> > in grub and the screen changes graphics mode and by the time it has
> > finished the switch the computer reboots.
Can you send me your .config and I'll try to reproduce?
Thanks,
Matt
--
Matt Domsch
Sr. Software Engineer, Lead Engineer
Dell Linux Solutions www.dell.com/linux
Linux on Dell mailing lists @ http://lists.us.dell.com
next prev parent reply other threads:[~2003-12-05 17:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-04 14:20 2.4.23 compile error in edd Meelis Roos
2003-12-04 14:58 ` Meelis Roos
2003-12-04 22:31 ` 2.4.23-bk bogus edd changeset - " Anton Altaparmakov
2003-12-05 15:52 ` Marcelo Tosatti
2003-12-05 17:36 ` Matt Domsch [this message]
2003-12-05 18:53 ` Matt Domsch
2003-12-05 19:07 ` Matt Domsch
2003-12-08 16:34 ` Anton Altaparmakov
2003-12-09 4:23 ` Matt Domsch
2003-12-09 16:29 ` Anton Altaparmakov
2003-12-10 20:48 ` Matt Domsch
2003-12-15 19:52 ` Anton Altaparmakov
2003-12-18 11:32 ` Meelis Roos
2003-12-18 14:02 ` Matt Domsch
2003-12-19 11:05 ` Meelis Roos
2003-12-19 14:49 ` Matt Domsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031205113619.A20371@lists.us.dell.com \
--to=matt_domsch@dell.com \
--cc=aia21@cam.ac.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
--cc=mroos@linux.ee \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).