From: Christoph Hellwig <hch@infradead.org>
To: Nathan Scott <nathans@sgi.com>
Cc: Linus Torvalds <torvalds@osdl.org>,
pinotj@club-internet.fr, manfred@colorfullife.com, akpm@osdl.org,
linux-kernel@vger.kernel.org
Subject: Re: [Oops] i386 mm/slab.c (cache_flusharray)
Date: Fri, 5 Dec 2003 14:22:38 +0000 [thread overview]
Message-ID: <20031205142238.A26578@infradead.org> (raw)
In-Reply-To: <20031205203425.B2091516@wobbly.melbourne.sgi.com>; from nathans@sgi.com on Fri, Dec 05, 2003 at 08:34:25PM +1100
On Fri, Dec 05, 2003 at 08:34:25PM +1100, Nathan Scott wrote:
> You might be mixing up pb_pages and pb_addr there? pb_addr is
> always a pointer. We need to distinguish whether it was slab
> alloc'd or whether it points into page cache pages, so we know
> whether to page_cache_release the pages or kfree the pointer
> when we're done with the pagebuf.
>
> The pb_page_array works just as you describe, with a prealloc'd
> array of page pointers, and pb_pages either points to the array
> of to a larger kmalloc'd array as necessary.
Indeed. I'm not remembering the code as good as I hoped to :)
Sorry for the noise.
next prev parent reply other threads:[~2003-12-05 14:22 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-04 18:27 [Oops] i386 mm/slab.c (cache_flusharray) pinotj
2003-12-04 18:49 ` Linus Torvalds
2003-12-04 19:09 ` Linus Torvalds
2003-12-04 21:21 ` Nathan Scott
2003-12-05 7:14 ` Christoph Hellwig
2003-12-05 9:34 ` Nathan Scott
2003-12-05 14:22 ` Christoph Hellwig [this message]
2003-12-05 3:00 ` Nathan Scott
2003-12-05 6:40 ` Linus Torvalds
2003-12-04 19:19 ` Manfred Spraul
2003-12-04 21:26 ` Nathan Scott
-- strict thread matches above, loose matches on Subject: below --
2003-12-09 0:57 pinotj
2003-12-09 2:03 ` Nathan Scott
2003-12-09 7:21 ` Christoph Hellwig
2003-12-09 23:58 ` Nathan Scott
2003-12-12 19:00 ` Christoph Hellwig
2003-12-12 20:07 ` Manfred Spraul
2003-12-03 23:06 pinotj
2003-12-03 23:26 ` Linus Torvalds
2003-11-29 17:41 pinotj
2003-12-02 0:36 ` Linus Torvalds
2003-12-02 1:37 ` Nathan Scott
2003-12-02 6:44 ` Nathan Scott
2003-12-02 18:05 ` Mike Fedyk
2003-12-02 20:05 ` Nathan Scott
2003-11-27 18:42 pinotj
2003-11-27 18:55 ` Manfred Spraul
2003-12-02 1:03 ` Mike Fedyk
2003-11-25 17:30 pinotj
2003-11-25 22:51 ` Linus Torvalds
2003-11-27 18:07 ` Manfred Spraul
2003-11-22 7:47 Re: " pinotj
2003-11-22 10:55 ` Manfred Spraul
2003-11-21 18:12 pinotj
2003-11-21 18:58 ` Manfred Spraul
2003-11-20 1:50 pinotj
2003-11-20 2:09 ` Andrew Morton
2003-11-19 18:19 pinotj
2003-11-20 1:07 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031205142238.A26578@infradead.org \
--to=hch@infradead.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
--cc=nathans@sgi.com \
--cc=pinotj@club-internet.fr \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).