From: Adrian Bunk <bunk@fs.tum.de>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: netdev@oss.sgi.com, torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: [patch] remove com20020-isa.c unused variables
Date: Sat, 6 Dec 2003 09:57:36 +0100 [thread overview]
Message-ID: <20031206085736.GQ20739@fs.tum.de> (raw)
In-Reply-To: <20031205192828.GA15907@gtf.org>
Hi Jeff,
your experimental net driver queue patch introduced the following
compile warnings when compiling com20020-isa statically into the kernel:
<-- snip -->
...
CC drivers/net/arcnet/com20020-isa.o
drivers/net/arcnet/com20020-isa.c: In function `com20020isa_setup':
drivers/net/arcnet/com20020-isa.c:189: warning: unused variable `lp'
drivers/net/arcnet/com20020-isa.c:188: warning: unused variable `dev'
...
<-- snip -->
The fix is trivial (the net driver queue patch removes all uses of
these variables):
--- linux-2.6.0-test11-full-no-smp/drivers/net/arcnet/com20020-isa.c.old 2003-12-06 09:51:10.000000000 +0100
+++ linux-2.6.0-test11-full-no-smp/drivers/net/arcnet/com20020-isa.c 2003-12-06 09:53:41.000000000 +0100
@@ -185,8 +185,6 @@
#ifndef MODULE
static int __init com20020isa_setup(char *s)
{
- struct net_device *dev;
- struct arcnet_local *lp;
int ints[8];
s = get_options(s, 8, ints);
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
prev parent reply other threads:[~2003-12-06 8:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-05 19:28 [BK PATCHES] 2.6.x experimental net driver queue Jeff Garzik
2003-12-05 19:47 ` new e100 (was Re: [BK PATCHES] 2.6.x experimental net driver queue) Jeff Garzik
2003-12-06 8:57 ` Adrian Bunk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031206085736.GQ20739@fs.tum.de \
--to=bunk@fs.tum.de \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).