From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263463AbTLFJFr (ORCPT ); Sat, 6 Dec 2003 04:05:47 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S264264AbTLFJFr (ORCPT ); Sat, 6 Dec 2003 04:05:47 -0500 Received: from mail.kroah.org ([65.200.24.183]:11492 "EHLO perch.kroah.org") by vger.kernel.org with ESMTP id S263463AbTLFJFq (ORCPT ); Sat, 6 Dec 2003 04:05:46 -0500 Date: Sat, 6 Dec 2003 01:04:14 -0800 From: Greg KH To: Jeff Garzik Cc: Jim Keniston , LKML , netdev , Andrew Morton , "Feldman, Scott" , Larry Kessler , "David S. Miller" , Linus Torvalds Subject: Re: [PATCH 2.6.0-test11] Net device error logging Message-ID: <20031206090414.GA23445@kroah.com> References: <3FD0E1FE.1D5B1883@us.ibm.com> <3FD0E498.8070703@pobox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3FD0E498.8070703@pobox.com> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 05, 2003 at 03:03:36PM -0500, Jeff Garzik wrote: > I discussed this a bit with David. My personal feelings are that I > prefer just leaving all the printk's as they are. But Linus and GregKH > have been accepting patches into other parts of the tree like this one, > and logging additional already-computer-parsed information is probably > not a bad thing long-term, so perhaps I've been being a bit of a Luddite > on this issue. To be fair, the patches I've taken (dev_err and friends) are _much_ simpler than these, so accepting them was not that big of a deal. It enabled the subsystems that have started to use them (USB and I2C) to log better messages (we now know exactly which device caused the errors, instead of just which driver). So please judge this patch on its own, and feel no pressure due to the dev_*() calls :) thanks, greg k-h