From: Jon Smirl <jonsmirl@yahoo.com>
To: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
Ulrich Drepper <drepper@redhat.com>
Cc: Jon Smirl <jonsmirl@yahoo.com>, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] FIx 'noexec' behavior
Date: Sat, 6 Dec 2003 12:15:22 -0800 (PST) [thread overview]
Message-ID: <20031206201522.44780.qmail@web14914.mail.yahoo.com> (raw)
In-Reply-To: <87n0a590th.fsf@devron.myhome.or.jp>
This seems to fix it:
[jonsmirl@smirl mm]$ bk diffs
===== mmap.c 1.94 vs edited =====
481c481
< if ((prot & PROT_EXEC) && (file->f_vfsmnt->mnt_flags & MNT_NOEXEC))
---
> if (file && (prot & PROT_EXEC) && (file->f_vfsmnt->mnt_flags & MNT_NOEXE
C))
[jonsmirl@smirl mm]$
Although I didn't have any oops on my console, in dmesg or messages.
--- OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> wrote:
> Ulrich Drepper <drepper@redhat.com> writes:
>
> if (file && (!file->f_op || !file->f_op->mmap))
> return -ENODEV;
>
> if ((prot & PROT_EXEC) && (file->f_vfsmnt->mnt_flags & MNT_NOEXEC))
> return -EPERM;
>
> Probably he get the oops, because file can be NULL.
> --
> OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
=====
Jon Smirl
jonsmirl@yahoo.com
__________________________________
Do you Yahoo!?
New Yahoo! Photos - easier uploading and sharing.
http://photos.yahoo.com/
next prev parent reply other threads:[~2003-12-06 20:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-06 19:18 [PATCH] FIx 'noexec' behavior Jon Smirl
2003-12-06 19:34 ` Ulrich Drepper
2003-12-06 19:57 ` OGAWA Hirofumi
2003-12-06 20:15 ` Jon Smirl [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-12-07 13:39 Alex Riesen
2003-12-07 13:42 ` William Lee Irwin III
2003-12-07 16:19 ` Alex Riesen
2003-12-07 12:06 Alex Riesen
2003-12-07 12:17 ` William Lee Irwin III
[not found] <20031206200322.86264.qmail@web14902.mail.yahoo.com>
2003-12-06 20:07 ` Ulrich Drepper
2003-12-06 17:27 Jon Smirl
2003-12-06 18:20 ` Ulrich Drepper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031206201522.44780.qmail@web14914.mail.yahoo.com \
--to=jonsmirl@yahoo.com \
--cc=drepper@redhat.com \
--cc=hirofumi@mail.parknet.co.jp \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).