linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Maneesh Soni <maneesh@in.ibm.com>
To: James W McMechan <mcmechanjw@juno.com>
Cc: hugh@veritas.com, linux-kernel@vger.kernel.org,
	wli@holomorphy.com, viro@parcelfarce.linux.theplanet.co.uk,
	akpm@osdl.org
Subject: Re: Oops with tmpfs on both 2.4.22 & 2.6.0-test11
Date: Mon, 8 Dec 2003 10:40:37 +0530	[thread overview]
Message-ID: <20031208051037.GB4667@in.ibm.com> (raw)
In-Reply-To: <20031207.140732.-1654081.3.mcmechanjw@juno.com>

On Sun, Dec 07, 2003 at 02:07:28PM -0800, James W McMechan wrote:
> After tinkering with patches for the last week I finally have a version
> that does not look quite so bad, my first attempts at improvement were
> awful in their awkwardness.
> The problem was that the cursor was in the list being walked, and when
> the pointer pointed to the cursor the list_del/list_add_tail pair would
> Oops trying to find the entry pointed to by the prev pointer of the
> freshly deleted cursor element.
> 
> The solution I finally found was to move the list_del earlier, before the
> beginning of the list walk, since it is not used during the list walk and
> should not count in the list enumeration it can be deleted, then the list
> pointer cannot point to it so it can be added safely with the
> list_add_tail
> without Oopsing, and everything works as expected I am unable to Oops
> this
> version with any of my test programs.
> 
> And of course since this Oops both 2.4 & 2.6 I will need to prepare
> a second set for the 2.4 tree.
> 
> My question to you who expressed interest, is anything odd looking about
> this code, anything that I am doing wrong or could do better?
> 

Looks better than my patch. The aim of dcache_dir_lseek() is to put the
cursor dentry at the required position and thats what it is doing now, deletes
the cursor, finds the desired location and then puts it there.

Thanks
Maneesh


-- 
Maneesh Soni
Linux Technology Center, 
IBM Software Lab, Bangalore, India
email: maneesh@in.ibm.com
Phone: 91-80-5044999 Fax: 91-80-5268553
T/L : 9243696

       reply	other threads:[~2003-12-08  5:12 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20031207.140732.-1654081.3.mcmechanjw@juno.com>
2003-12-08  5:10 ` Maneesh Soni [this message]
2003-12-07 22:48 James McMechan
  -- strict thread matches above, loose matches on Subject: below --
2003-12-03 11:06 James W McMechan
2003-12-03 12:02 ` Maneesh Soni
2003-12-01  2:59 James W McMechan
2003-12-01 11:37 ` Maneesh Soni
2003-12-01  2:06 James W McMechan
2003-12-01  4:51 ` William Lee Irwin III
2003-12-01  1:06 James W McMechan
2003-12-01  3:43 ` William Lee Irwin III
2003-11-30 21:17 James W McMechan
2003-12-01  1:21 ` William Lee Irwin III
2003-12-01  7:58   ` Andries Brouwer
2003-12-01  8:00     ` William Lee Irwin III
2003-11-30 17:34 James W McMechan
2003-11-30 20:06 ` William Lee Irwin III
2003-11-30 21:21   ` Oleg Drokin
2003-11-30 16:57 James W McMechan
2003-11-30 19:27 ` William Lee Irwin III

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031208051037.GB4667@in.ibm.com \
    --to=maneesh@in.ibm.com \
    --cc=akpm@osdl.org \
    --cc=hugh@veritas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcmechanjw@juno.com \
    --cc=viro@parcelfarce.linux.theplanet.co.uk \
    --cc=wli@holomorphy.com \
    --subject='Re: Oops with tmpfs on both 2.4.22 & 2.6.0-test11' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).