From: Dmitry Torokhov <dtor_core@ameritech.net>
To: Peter Berg Larsen <pebl@math.ku.dk>
Cc: Santiago Garcia Mantinan <manty@manty.net>,
Lukas Hejtmanek <xhejtman@mail.muni.cz>,
Michal Jaegermann <michal@harddata.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: Synaptics PS/2 driver and 2.6.0-test11
Date: Mon, 8 Dec 2003 13:16:46 -0500 [thread overview]
Message-ID: <200312081316.47899.dtor_core@ameritech.net> (raw)
In-Reply-To: <Pine.LNX.4.40.0312081021080.10795-100000@shannon.math.ku.dk>
On Monday 08 December 2003 04:54 am, Peter Berg Larsen wrote:
> On Sun, 7 Dec 2003, Dmitry Torokhov wrote:
> > The difference is that GPM (I assume you are using it to get
> > Synaptics support) only logs "protocol violations" when in debug
> > mode, and then it only checks 2 first bytes.
>
> No, gpm checks the first byte and decide whether to read the following
> 5 bytes (or trough the byte away). The synaptics driver itself does the
> same tests as the kernelcode (and reports an error).
>
> Peter
You are right, Synaptics does check entire packet and reports it,
unfortunately many (most) distributions kill almost all GPM messages
because it's too noisy.
Anyway, I wonder if the patch below will help sync problem. If it does
then we can kill the warning message later.
The patch should apply to -test11 although will complain about offset
as I have some extra stuff in my tree.
Dmitry
===== drivers/input/mouse/psmouse-base.c 1.40 vs edited =====
--- 1.40/drivers/input/mouse/psmouse-base.c Sun Dec 7 02:05:20 2003
+++ edited/drivers/input/mouse/psmouse-base.c Mon Dec 8 13:05:05 2003
@@ -125,6 +125,13 @@
if (psmouse->state == PSMOUSE_IGNORE)
goto out;
+ if (flags & (SERIO_PARITY|SERIO_TIMEOUT)) {
+ printk(KERN_WARNING "psmouse: bad data from KBC -%s%s\n",
+ flags & SERIO_TIMEOUT ? " timeout" : "",
+ flags & SERIO_PARITY ? " bad parity" : "");
+ goto out;
+ }
+
if (psmouse->acking) {
switch (data) {
case PSMOUSE_RET_ACK:
next prev parent reply other threads:[~2003-12-08 18:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-30 21:46 Synaptics PS/2 driver and 2.6.0-test11 Lukas Hejtmanek
2003-11-30 22:28 ` Dmitry Torokhov
2003-11-30 22:39 ` Lukas Hejtmanek
2003-11-30 23:26 ` Dmitry Torokhov
2003-11-30 23:40 ` Lukas Hejtmanek
2003-12-01 3:25 ` Michal Jaegermann
2003-12-06 12:37 ` Kjartan Maraas
2003-12-07 19:44 ` Lukas Hejtmanek
2003-12-07 22:10 ` Santiago Garcia Mantinan
2003-12-08 0:54 ` Dmitry Torokhov
2003-12-08 9:54 ` Peter Berg Larsen
2003-12-08 18:16 ` Dmitry Torokhov [this message]
2003-12-14 23:10 ` Lukas Hejtmanek
2003-12-08 11:22 ` Santiago Garcia Mantinan
[not found] ` <20031130230144.GA2124@rivenstone.net>
2003-11-30 23:11 ` Lukas Hejtmanek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200312081316.47899.dtor_core@ameritech.net \
--to=dtor_core@ameritech.net \
--cc=linux-kernel@vger.kernel.org \
--cc=manty@manty.net \
--cc=michal@harddata.com \
--cc=pebl@math.ku.dk \
--cc=xhejtman@mail.muni.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).