linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: William Lee Irwin III <wli@holomorphy.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [patch] sched-HT-2.6.0-test11-A5
Date: Mon, 8 Dec 2003 09:56:22 -0800	[thread overview]
Message-ID: <20031208175622.GY19856@holomorphy.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0312011102540.3323@earth>

On Mon, Dec 01, 2003 at 11:08:17AM +0100, Ingo Molnar wrote:
> i've uploaded the HT scheduler patch against 2.6.0-test11 to:
>     redhat.com/~mingo/O(1)-scheduler/sched-HT-2.6.0-test11-A5
> note, the patch includes a fix to sync wakeups, which might hurt lat_ctx.  
> I've attached the fix against vanilla 2.6.0-test11 as well.

This appears to either leak migration threads or not set
rq->cpu[x].migration_thread basically ever for x > 0. Or if they
are shut down, how? Also, what makes sure cpu_idx is initialized
before they wake? They'll all spin on cpu_rq(0)->lock, no?

Furthermore, sched_map_runqueue() is performed after all the idle
threads are running and all the notifiers have kicked the migration
threads, but does no locking whatsoever.

Also, does init_idle() need to move into rest_init()? It should be
equivalent to its current placement.

Why not per_cpu for __rq_idx[] and __cpu_idx[]? This would have the
advantage of residing on node-local memory for sane architectures
(and perhaps in the future, some insane ones).

-- wli

  parent reply	other threads:[~2003-12-08 17:56 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20031117021511.GA5682@averell>
     [not found] ` <3FB83790.3060003@cyberone.com.au>
     [not found]   ` <20031117141548.GB1770@colin2.muc.de>
     [not found]     ` <Pine.LNX.4.56.0311171638140.29083@earth>
     [not found]       ` <20031118173607.GA88556@colin2.muc.de>
     [not found]         ` <Pine.LNX.4.56.0311181846360.23128@earth>
     [not found]           ` <20031118235710.GA10075@colin2.muc.de>
     [not found]             ` <3FBAF84B.3050203@cyberone.com.au>
     [not found]               ` <501330000.1069443756@flay>
     [not found]                 ` <3FBF099F.8070403@cyberone.com.au>
     [not found]                   ` <1010800000.1069532100@[10.10.2.4]>
     [not found]                     ` <3FC01817.3090705@cyberone.com.au>
2003-11-23 11:57                       ` [RFC] generalise scheduling classes Nick Piggin
2003-11-23 12:01                         ` Ingo Molnar
2003-11-23 12:15                           ` Nick Piggin
2003-11-23 12:21                             ` Ingo Molnar
2003-11-23 16:26                           ` Martin J. Bligh
2003-12-01 10:08                             ` [patch] sched-HT-2.6.0-test11-A5 Ingo Molnar
2003-12-06 19:01                               ` Martin J. Bligh
2003-12-06 21:40                                 ` Zwane Mwaikambo
2003-12-07 13:34                                   ` Ingo Molnar
2003-12-07 16:39                                     ` Anton Blanchard
2003-12-07 17:16                                       ` Martin J. Bligh
2003-12-07 18:31                                         ` Zwane Mwaikambo
2003-12-07 20:17                                         ` Anton Blanchard
2003-12-08 17:57                                           ` Ingo Molnar
2003-12-07 17:22                                       ` Anton Blanchard
2003-12-08 17:56                               ` William Lee Irwin III [this message]
2003-12-08 18:21                                 ` Ingo Molnar
2003-12-08 19:12                                   ` William Lee Irwin III
2003-12-08 22:20                                   ` age
2003-12-08 19:36                                 ` William Lee Irwin III
2003-11-23 21:38                         ` [RFC] generalise scheduling classes William Lee Irwin III
2003-11-24  2:19                           ` Nick Piggin
2003-11-24  1:06                         ` Anton Blanchard
2003-11-24  2:26                           ` Nick Piggin
2003-11-24  2:39                             ` Davide Libenzi
2003-11-24 22:48                         ` bill davidsen
2003-11-25  1:46                           ` Nick Piggin
2003-11-25 16:23                             ` Bill Davidsen
2003-11-30  9:35                   ` [RFC] Further SMP / NUMA scheduler improvements Nick Piggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031208175622.GY19856@holomorphy.com \
    --to=wli@holomorphy.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).