From: viro@parcelfarce.linux.theplanet.co.uk
To: Tsuchiya Yoshihiro <tsuchiya@labs.fujitsu.com>
Cc: Bryan Whitehead <driver@jpl.nasa.gov>,
"Stephen C. Tweedie" <sct@redhat.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: filesystem bug?
Date: Tue, 16 Dec 2003 23:40:24 +0000 [thread overview]
Message-ID: <20031216234024.GP4176@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <3FDF95EB.2080903@labs.fujitsu.com>
On Wed, Dec 17, 2003 at 08:31:55AM +0900, Tsuchiya Yoshihiro wrote:
> Hi,
>
> Stephen, I don't have anything helpful for debuging at this point. We
> noticed the problem
> by debuging our SCSI driver. Then we found that the same thing happens
> on generic
> SCSI disk and IDE also. The problem we observed in our driver was that
> while it is
> processing a buffer, which should be locked by BH_LOCK, the contents of
> the buffer were
> overwritten. The amount of overwrite is a few byte to 1KB out of 4KB,
> which cannot be done
> in our driver. Then, we tried a generic SCSI and I reproduced the problem.
> I think it is not because of a broken pointer because overwrites only
> happen in data buffers
> and other parts of memory seem ok.
Umm... You do realize that if you have a shared writable mapping, the
buffer contents _can_ change during the IO? Legitimately. When dirty
page is being written to disk, it remains mapped. So process can change
its contents just fine.
BH_LOCK does not prevent that and it was never supposed to...
next prev parent reply other threads:[~2003-12-16 23:40 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-15 9:25 filesystem bug? Tsuchiya Yoshihiro
2003-12-15 9:55 ` bert hubert
2003-12-16 13:44 ` Stephen C. Tweedie
2003-12-16 21:40 ` Bryan Whitehead
2003-12-16 21:50 ` Bryan Whitehead
2003-12-16 23:31 ` Tsuchiya Yoshihiro
2003-12-16 23:40 ` viro [this message]
2003-12-17 0:12 ` Tsuchiya Yoshihiro
2003-12-17 23:24 ` Tsuchiya Yoshihiro
2003-12-18 21:29 ` Stephen C. Tweedie
2003-12-21 23:15 ` Tsuchiya Yoshihiro
2003-12-22 1:54 ` Tsuchiya Yoshihiro
2003-12-22 4:30 ` Tsuchiya Yoshihiro
2003-12-22 12:03 ` Stephen C. Tweedie
2003-12-24 1:48 ` Tsuchiya Yoshihiro
2003-12-24 23:09 ` Tsuchiya Yoshihiro
2004-01-15 6:38 ` Tsuchiya Yoshihiro
2003-12-26 9:59 ` dlion
2003-12-26 12:27 ` dlion
2003-12-26 13:22 土屋芳浩
2003-12-26 14:30 ` dlion
2003-12-28 8:26 ` dlion
2003-12-27 14:35 Tsuchiya Yoshihiro
[not found] ` <Pine.LNX.4.58L.0312301556380.23875@logos.cnet>
[not found] ` <74964CA8-3B50-11D8-B879-00039341E01A@ybb.ne.jp>
[not found] ` <1074109164.4538.8.camel@sisko.scot.redhat.com>
[not found] ` <0586254E-46DA-11D8-B45E-00039341E01A@ybb.ne.jp>
2004-01-15 22:38 ` Stephen C. Tweedie
2004-01-16 2:59 Tsuchiya Yoshihiro
2004-01-16 12:29 ` Stephen C. Tweedie
2004-01-19 7:52 ` Tsuchiya Yoshihiro
2004-01-19 13:12 ` Stephen C. Tweedie
2004-01-20 8:36 ` Tsuchiya Yoshihiro
2004-01-20 16:27 ` Stephen C. Tweedie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031216234024.GP4176@parcelfarce.linux.theplanet.co.uk \
--to=viro@parcelfarce.linux.theplanet.co.uk \
--cc=driver@jpl.nasa.gov \
--cc=linux-kernel@vger.kernel.org \
--cc=sct@redhat.com \
--cc=tsuchiya@labs.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).