From: Tom Rini <trini@kernel.crashing.org>
To: Meelis Roos <mroos@linux.ee>
Cc: linux-kernel@vger.kernel.org
Subject: Re: PPC & 2.6.0-test3: wrong mem size & hang on ifconfig
Date: Wed, 24 Dec 2003 14:20:22 -0700 [thread overview]
Message-ID: <20031224212022.GN4023@stop.crashing.org> (raw)
In-Reply-To: <Pine.GSO.4.44.0312111357130.24419-100000@math.ut.ee>
On Thu, Dec 11, 2003 at 03:51:34PM +0200, Meelis Roos wrote:
> > ===== arch/ppc/boot/prep/misc.c 1.14 vs edited =====
> > --- 1.14/arch/ppc/boot/prep/misc.c Mon Oct 20 11:49:35 2003
> > +++ edited/arch/ppc/boot/prep/misc.c Wed Dec 10 09:11:05 2003
> > @@ -251,15 +251,21 @@
> > {
> > phandle dev_handle;
> > int mem_info[2];
> > + int n;
> > + puts("Trying OF\n");
> >
> > /* get handle to memory description */
> > if (!(dev_handle = finddevice("/memory@0")))
> > break;
> > + puts("Found /memory@0\n");
> >
> > /* get the info */
> > if (getprop(dev_handle, "reg", mem_info,
> > - sizeof(mem_info) != 8))
> > + sizeof(mem_info) != 8)) {
> > + puts("n = 0x");puthex(n);puts("\n");
> > break;
> > + }
> > + puts("Found reg prop\n");
>
> Are you sure that n really gets a value?
>
> It prints
> Found /memory@0
> n = 0x00000000
>
> and nothinf about reg prop as the code tells. What do you actually mean
> by n?
Sorry for such a late reply. What I ment to do in there was:
if ((n = getprop(dev_handle, "reg", mem_info, sizeof(mem_info))
!= 8) {
puts("n = 0x";puthex(n);puts("\n");
break;
}
--
Tom Rini
http://gate.crashing.org/~trini/
next prev parent reply other threads:[~2003-12-24 21:20 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-18 19:12 PPC & 2.6.0-test3: wrong mem size & hang on ifconfig Meelis Roos
2003-08-29 18:49 ` Tom Rini
2003-10-10 9:20 ` Meelis Roos
2003-10-13 16:02 ` Tom Rini
2003-10-14 18:25 ` Meelis Roos
2003-10-14 18:42 ` Tom Rini
2003-10-14 18:44 ` Meelis Roos
2003-10-14 18:53 ` Tom Rini
2003-10-14 19:58 ` Meelis Roos
2003-10-14 23:25 ` Tom Rini
2003-10-20 13:55 ` Meelis Roos
2003-10-20 15:30 ` Tom Rini
2003-10-20 15:41 ` Meelis Roos
2003-10-20 20:33 ` Tom Rini
2003-10-22 15:31 ` Meelis Roos
2003-10-22 15:47 ` Tom Rini
2003-12-10 13:21 ` Meelis Roos
2003-12-10 16:11 ` Tom Rini
2003-12-11 13:51 ` Meelis Roos
2003-12-24 21:20 ` Tom Rini [this message]
2004-01-06 12:00 ` Meelis Roos
2004-01-06 15:37 ` Tom Rini
2004-08-19 10:48 ` Meelis Roos
2004-09-01 18:44 ` Tom Rini
2003-10-13 22:46 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031224212022.GN4023@stop.crashing.org \
--to=trini@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mroos@linux.ee \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).