From: Gene Heskett <gene.heskett@verizon.net>
To: Rusty Russell <rusty@rustcorp.com.au>,
Omkhar Arasaratnam <omkhar@rogers.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/scsi/advansys.c check_region() fix
Date: Wed, 7 Jan 2004 23:09:14 -0500 [thread overview]
Message-ID: <200401072309.14401.gene.heskett@verizon.net> (raw)
In-Reply-To: <20040108002255.69A532C46A@lists.samba.org>
On Wednesday 07 January 2004 18:26, Rusty Russell wrote:
>In message <20031230134433.GA22187@omkhar.ibm.com> you write:
>> Another trivial check_region() fix verified by Gene
>
>And almost certainly wrong.
I'm the "Gene", Rusty. What symptoms would I see if its wrong?
Memory leak? Instability? My dog falls over before his time? My
pickup throws a rod?
In my case, its only running a small 4 tape Seagate changer, so it
doesn't get a lot of exersize other than by amanda's nightly run.
>The *point* of request_region() is that you do it before any I/O to
>the region.
>
>So you can't release it before calling AscGetChipVersion().
>
>Converting this driver is quite a bit of work, since you have to
> trace down every path which uses the region and make sure it's
> covered. The fact that it's formatted like an angry haiku doesn't
> help.
I noticed, gawd, that looks like a bowl of spagetti and I'm nowhere
near the coder you fellows are. But it did get rid of the compiler
warnings about check_region().
--
Cheers, Gene
AMD K6-III@500mhz 320M
Athlon1600XP@1400mhz 512M
99.22% setiathome rank, not too shabby for a WV hillbilly
Yahoo.com attornies please note, additions to this message
by Gene Heskett are:
Copyright 2003 by Maurice Eugene Heskett, all rights reserved.
prev parent reply other threads:[~2004-01-08 4:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-30 13:44 [PATCH] drivers/scsi/advansys.c check_region() fix Omkhar Arasaratnam
2004-01-07 23:26 ` Rusty Russell
2004-01-08 4:09 ` Gene Heskett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200401072309.14401.gene.heskett@verizon.net \
--to=gene.heskett@verizon.net \
--cc=linux-kernel@vger.kernel.org \
--cc=omkhar@rogers.com \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).