From: Jens Axboe <axboe@suse.de>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>,
Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
Subject: Re: [PATCH] 2.6.1-rc2 ide barrier support
Date: Fri, 9 Jan 2004 08:26:00 +0100 [thread overview]
Message-ID: <20040109072600.GA18416@suse.de> (raw)
In-Reply-To: <1073615696.784.181.camel@gaston>
On Fri, Jan 09 2004, Benjamin Herrenschmidt wrote:
>
> > + char special_buf[8]; /* private command buffer */
>
> Why not put that in struct drive instead ? You must be a bit more
> careful on the lifetime, but it's less bloat, there are much less
> instances of struct drive than struct request :)
Hmm? It _is_ in struct drive :-). It could be put in hwgroup actually,
but I felt it was cleaner in drive (and easier to manage).
--
Jens Axboe
next prev parent reply other threads:[~2004-01-09 7:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-07 13:43 [PATCH] 2.6.1-rc2 ide barrier support Jens Axboe
2004-01-07 18:45 ` Bartlomiej Zolnierkiewicz
2004-01-08 8:31 ` Jens Axboe
2004-01-09 2:34 ` Benjamin Herrenschmidt
2004-01-09 7:26 ` Jens Axboe [this message]
2004-01-09 13:45 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040109072600.GA18416@suse.de \
--to=axboe@suse.de \
--cc=B.Zolnierkiewicz@elka.pw.edu.pl \
--cc=akpm@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).