From: Andrew Morton <akpm@osdl.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: linux-kernel@vger.kernel.org
Subject: Re: suspend/resume support for PIT (time.c)
Date: Sat, 10 Jan 2004 14:46:24 -0800 [thread overview]
Message-ID: <20040110144624.1571488f.akpm@osdl.org> (raw)
In-Reply-To: <20040110200332.GA1327@elf.ucw.cz>
Pavel Machek <pavel@ucw.cz> wrote:
>
> +static int pit_resume(struct sys_device *dev)
> +{
> + write_seqlock_irq(&xtime_lock);
> + xtime.tv_sec = get_cmos_time() + clock_cmos_diff;
> + xtime.tv_nsec = 0;
> + write_sequnlock_irq(&xtime_lock);
> + return 0;
> +}
Have you checked the lock ranking here? get_cmos_time() takes a ton of
locks, especially if EFI is enabled. Do all those rank inside xtime_lock?
It _looks_ right, but perhaps it would be saner to move the get_coms_time()
call outside the lock?
next prev parent reply other threads:[~2004-01-10 22:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-10 20:03 suspend/resume support for PIT (time.c) Pavel Machek
2004-01-10 22:46 ` Andrew Morton [this message]
2004-01-11 11:53 ` Pavel Machek
2004-01-12 18:33 ` john stultz
2004-01-12 22:39 ` Pavel Machek
2004-01-12 23:12 ` Andrew Morton
2004-01-12 23:14 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040110144624.1571488f.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).