From: Greg KH <greg@kroah.com>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] restrict class names to valid file names
Date: Mon, 12 Jan 2004 16:18:33 -0800 [thread overview]
Message-ID: <20040113001833.GB4848@kroah.com> (raw)
In-Reply-To: <20040112161336.3e147996.shemminger@osdl.org>
On Mon, Jan 12, 2004 at 04:13:36PM -0800, Stephen Hemminger wrote:
> On Mon, 12 Jan 2004 16:05:14 -0800
> Greg KH <greg@kroah.com> wrote:
>
> > On Mon, Jan 12, 2004 at 03:13:57PM -0800, Stephen Hemminger wrote:
> > > It is possible to name network devices with names like "my/bogus" or "." or ".."
> > > which leaves /sys/class/net/ a mess. Since other subsystems could have the same
> > > problem, it made sense to me to enforce some restrictions in the class device
> > > layer.
> > >
> > > A lateer patch fixes the network device registration path because the
> > > sysfs registration takes place after the register_netdevice call has taken place.
> >
> > Heh, so you will have already "scrubbed" the name before you submit it
> > to the driver core? If so, why add this patch?
>
> Because name won't be scrubbed for the rename case
Why not? Does that mean that those characters are valid names for
network devices if the device is renamed from userspace?
> , and other class devices probably have the same possible problem
I don't know of any other class device code in the kernel that accepts
userspace input as its name.
thanks,
greg k-h
prev parent reply other threads:[~2004-01-13 0:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-12 23:13 [PATCH] restrict class names to valid file names Stephen Hemminger
2004-01-13 0:05 ` Greg KH
2004-01-13 0:13 ` Stephen Hemminger
2004-01-13 0:18 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040113001833.GB4848@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).