From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, acme@conectiva.com.br,
arobinso@nyx.net, support@moxa.com.tw, christoph@lameter.com,
pgmdsg@ibi.com, richard@sleepie.demon.co.uk,
R.E.Wolff@BitWizard.nl, fritz@isdn4linux.de,
reginak@cyclades.com, oli@bv.ro, jeff@uclinux.org,
macro@ds2.pg.gda.pl
Subject: Re: [3/3] 2.6 broken serial drivers
Date: Tue, 13 Jan 2004 21:10:23 +0000 [thread overview]
Message-ID: <20040113211023.H7256@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20040113122115.50265601.akpm@osdl.org>; from akpm@osdl.org on Tue, Jan 13, 2004 at 12:21:15PM -0800
On Tue, Jan 13, 2004 at 12:21:15PM -0800, Andrew Morton wrote:
> Russell King <rmk+lkml@arm.linux.org.uk> wrote:
> >
> > --- 1.14/drivers/net/wan/pc300_tty.c Thu Sep 11 18:40:53 2003
> > +++ edited/drivers/net/wan/pc300_tty.c Tue Jan 13 14:42:34 2004
> > @@ -583,6 +583,14 @@
> > CPC_TTY_DBG("%s: IOCTL cmd %x\n",cpc_tty->name,cmd);
> >
> > switch (cmd) {
> > +#error This is broken. See comments.
>
> Grumble. This breaks allmodconfig. #warning, please.
Probably far better to make all these drivers depend on BROKEN unless
one of the authors speaks up.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core
next prev parent reply other threads:[~2004-01-13 21:12 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-13 11:00 [PROBLEM] ircomm ioctls Jozef Vesely
2004-01-13 11:36 ` Russell King
2004-01-13 11:49 ` Outstanding fixups (was: Re: [PROBLEM] ircomm ioctls) Russell King
2004-01-13 17:15 ` Russell King
2004-01-13 17:24 ` [1/3] Serial fixups (mostly tested) Russell King
2004-01-24 6:16 ` [lkml] pseudo tty / kernel compile question Karl Tatgenhorst
2004-01-25 21:53 ` David Woodhouse
2004-01-13 17:33 ` [2/3] Russell King
2004-01-13 17:55 ` [2/3] Henrique Oliveira
2004-01-13 18:53 ` [2/3] John Stoffel
2004-01-13 22:15 ` [2/3] Paul Mackerras
2004-01-14 7:01 ` [2/3] Benjamin Herrenschmidt
2004-01-16 11:34 ` [2/3] Matthias Urlichs
2004-01-16 0:54 ` [2/3] Greg KH
2004-01-18 12:43 ` [2/3] Greg Ungerer
2004-01-18 15:42 ` [2/3] Russell King
2004-01-18 23:23 ` [2/3] Greg Ungerer
2004-01-13 17:42 ` [3/3] 2.6 broken serial drivers Russell King
2004-01-13 20:21 ` Andrew Morton
2004-01-13 21:10 ` Russell King [this message]
2004-01-18 16:16 ` Russell King
2004-01-14 12:42 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040113211023.H7256@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=R.E.Wolff@BitWizard.nl \
--cc=acme@conectiva.com.br \
--cc=akpm@osdl.org \
--cc=arobinso@nyx.net \
--cc=christoph@lameter.com \
--cc=fritz@isdn4linux.de \
--cc=jeff@uclinux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@ds2.pg.gda.pl \
--cc=oli@bv.ro \
--cc=pgmdsg@ibi.com \
--cc=reginak@cyclades.com \
--cc=richard@sleepie.demon.co.uk \
--cc=support@moxa.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).