* Re: [PATCH] Fix a 64bit bug in kobject module request
@ 2004-03-14 12:11 Mikael Pettersson
0 siblings, 0 replies; 2+ messages in thread
From: Mikael Pettersson @ 2004-03-14 12:11 UTC (permalink / raw)
To: ak, torvalds; +Cc: akpm, linux-kernel
On Thu, 11 Mar 2004 05:09:43 +0100, Andi Kleen wrote:
>>From Takashi Iwai
>
>kobj_lookup had a 64bit bug, which caused the request of a unknown
>character device to burn CPU instead of failing quickly.
>
>diff -burpN -X ../KDIFX linux-vanilla/drivers/base/map.c linux-2.6.4-amd64/drivers/base/map.c
>--- linux-vanilla/drivers/base/map.c 2003-09-23 08:03:40.000000000 +0200
>+++ linux-2.6.4-amd64/drivers/base/map.c 2004-03-08 15:23:45.000000000 +0100
>@@ -96,7 +96,7 @@ struct kobject *kobj_lookup(struct kobj_
> {
> struct kobject *kobj;
> struct probe *p;
>- unsigned best = ~0U;
>+ unsigned long best = ~0UL;
>
> retry:
> down_read(domain->sem);
My Athlon64 (FC1/x86_64 user-space) has been having mysterious
module autoloading failures where some modules (char-major-10-$N)
autoloaded just fine, but many ({char,block}-major-$N) did not.
This patch solved that problem.
Thanks Andi.
/Mikael
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] Fix a 64bit bug in kobject module request
@ 2004-03-11 4:09 Andi Kleen
0 siblings, 0 replies; 2+ messages in thread
From: Andi Kleen @ 2004-03-11 4:09 UTC (permalink / raw)
To: torvalds; +Cc: akpm, linux-kernel
>From Takashi Iwai
kobj_lookup had a 64bit bug, which caused the request of a unknown
character device to burn CPU instead of failing quickly.
diff -burpN -X ../KDIFX linux-vanilla/drivers/base/map.c linux-2.6.4-amd64/drivers/base/map.c
--- linux-vanilla/drivers/base/map.c 2003-09-23 08:03:40.000000000 +0200
+++ linux-2.6.4-amd64/drivers/base/map.c 2004-03-08 15:23:45.000000000 +0100
@@ -96,7 +96,7 @@ struct kobject *kobj_lookup(struct kobj_
{
struct kobject *kobj;
struct probe *p;
- unsigned best = ~0U;
+ unsigned long best = ~0UL;
retry:
down_read(domain->sem);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-03-14 12:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-03-14 12:11 [PATCH] Fix a 64bit bug in kobject module request Mikael Pettersson
-- strict thread matches above, loose matches on Subject: below --
2004-03-11 4:09 Andi Kleen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).