From: Jesse Barnes <jbarnes@sgi.com>
To: linux-kernel@vger.kernel.org
Cc: Matthew Wilcox <willy@debian.org>,
Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
Linux IA64 Mailing List <linux-ia64@vger.kernel.org>,
Hironobu Ishii <ishii.hironobu@jp.fujitsu.com>
Subject: Re: [RFC] readX_check() - Interface for PCI-X error recovery
Date: Tue, 6 Apr 2004 09:15:48 -0700 [thread overview]
Message-ID: <200404060915.48292.jbarnes@sgi.com> (raw)
In-Reply-To: <20040406115145.GA23258@parcelfarce.linux.theplanet.co.uk>
> > readX_check(dev,vaddr)
> > Read a register of the device mapped to vaddr, and check errors
> > if possible(This is depending on its architecture. In the case of
> > ia64, we can generate a MCA from an error by simple operation to
> > test the read data.)
> > If any error happen on the recoverable region, set the error flag.
>
> I really don't think we want another readX variant. Do we then also
> add readX_check_relaxed()? Can't we just pretend the MCA is asynchronous
> on ia64? I'm sure we'd get better performance.
Hmm.. I wonder if we could get away with not having a new readX interface by
registering each PCI resource either at driver init time or in arch code with
the MCA hander. Then we could just make the read routines use the variable
that was just read to try to flush out the MCA (there may be better ways to
do this). E.g.
arch_pci_scan()
{
...
for_each_pci_resource(dev, res) {
check_region(res);
}
...
}
...
unsigned char readb(unsigned long addr)
{
unsigned char val = *(volatile unsigned char *)addr;
#ifdef CONFIG_PCI_CHECK
/* try to flush out the MCA by doing something with val */
#endif
return val;
}
...
Then presumably the MCA error handler would see that an MCA occurred in a
region registered during PCI initialization and return an error for
pci_read_errors(dev);
Jesse
next prev parent reply other threads:[~2004-04-06 16:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-06 11:04 [RFC] readX_check() - Interface for PCI-X error recovery Hidetoshi Seto
2004-04-06 11:51 ` Matthew Wilcox
2004-04-06 16:15 ` Jesse Barnes [this message]
2004-04-07 9:34 ` Hidetoshi Seto
2004-04-07 2:08 ` Grant Grundler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200404060915.48292.jbarnes@sgi.com \
--to=jbarnes@sgi.com \
--cc=ishii.hironobu@jp.fujitsu.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=seto.hidetoshi@jp.fujitsu.com \
--cc=willy@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).