From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linux Kernel Development <linux-kernel@vger.kernel.org>
Subject: Re: {put,get}_user() side effects
Date: Tue, 6 Apr 2004 11:10:13 +0100 [thread overview]
Message-ID: <20040406111013.B15945@flint.arm.linux.org.uk> (raw)
In-Reply-To: <Pine.GSO.4.58.0404061159330.4158@waterleaf.sonytel.be>; from geert@linux-m68k.org on Tue, Apr 06, 2004 at 12:03:14PM +0200
On Tue, Apr 06, 2004 at 12:03:14PM +0200, Geert Uytterhoeven wrote:
> On most (all?) architectures {get,put}_user() has side effects:
>
> #define put_user(x,ptr) \
> __put_user_check((__typeof__(*(ptr)))(x),(ptr),sizeof(*(ptr)))
I thought this came up before, and it was decided that put_user and
get_user must not have such side effects - I certainly remember fixing
this very thing on ARM.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core
next prev parent reply other threads:[~2004-04-06 10:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-06 10:03 {put,get}_user() side effects Geert Uytterhoeven
2004-04-06 10:10 ` Russell King [this message]
[not found] <1HVGV-1Wl-21@gated-at.bofh.it>
2004-04-06 11:32 ` Andi Kleen
2004-04-06 11:46 ` Geert Uytterhoeven
2004-04-06 20:53 ` Horst von Brand
2004-04-06 22:53 ` Andreas Schwab
2004-04-06 11:50 ` Xavier Bestel
2004-04-06 12:17 ` Wichert Akkerman
2004-04-06 14:28 ` Xavier Bestel
2004-04-06 15:30 ` Kevin P. Fleming
2004-04-06 15:47 ` Xavier Bestel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040406111013.B15945@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).