From: Srivatsa Vaddagiri <vatsa@in.ibm.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: rusty@au1.ibm.com, nickpiggin@yahoo.com.au, akpm@osdl.org,
linux-kernel@vger.kernel.org, lhcs-devel@lists.sourceforge.net
Subject: Re: [Experimental CPU Hotplug PATCH] - Move migrate_all_tasks to CPU_DEAD handling
Date: Tue, 6 Apr 2004 20:23:48 +0530 [thread overview]
Message-ID: <20040406145348.GA8516@in.ibm.com> (raw)
In-Reply-To: <20040406072543.GA21626@elte.hu>
On Tue, Apr 06, 2004 at 09:25:43AM +0200, Ingo Molnar wrote:
> the question is, how much actual latency does the current 'freeze
> everything' solution cause? We should prefer simplicity and debuggability
> over cleverness of implementation - it's not like we'll have hotplug systems
> on everyone's desk in the next year or so.
>
> also, even assuming a hotplug CPU system, CPU replacement events are not
> that common, so the performance of the CPU-down op should not be a big
> issue. The function depends on the # of tasks only linearly, and we have
> tons of other code that is linear on the # of tasks - in fact we just
> finished removing all the quadratic functions.
Ingo,
I obtained some latency measurements of migrate_all_tasks() on
a 4-way 1.2 GHz Power4 PPC64 (p630) box. They are as below:
Number of Tasks Cycles (get_cycles) spent in migrate_all_tasks (ms)
===========================================================================
10536 803244 (5.3 ms)
30072 2587940 (17 ms)
Extending this to 100000 tasks makes the stoppage time to be for
8 million cycles (~50 ms).
My main concern of stopping the machine for so much time
was not performance, rather the effect it may have on functioning of the
system. The fact that we freeze the machine for (possibly) tons of
cycles doing nothing but migration made me uncomfortable. _and_ the fact that
it can very well be avoided :)
Can we rule out any side effects because of this stoppage? Watchdog timers,
cluster heartbeats, jiffies, ..? Not sure ..
It just felt much more "safe" and efficient to delegate migration to more
safer time in CPU_DEAD notification, when rest of the machine is running.
Plus this avoids the cpu_is_offline check in the more hotter path
(load_balance/try_to_wake_up)!!
--
Thanks and Regards,
Srivatsa Vaddagiri,
Linux Technology Center,
IBM Software Labs,
Bangalore, INDIA - 560017
next prev parent reply other threads:[~2004-04-06 14:53 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-05 12:18 [Experimental CPU Hotplug PATCH] - Move migrate_all_tasks to CPU_DEAD handling Srivatsa Vaddagiri
2004-04-06 0:28 ` Nick Piggin
2004-04-06 1:15 ` Srivatsa Vaddagiri
2004-04-06 1:27 ` Nick Piggin
2004-04-06 1:30 ` Nick Piggin
2004-04-06 16:43 ` [lhcs-devel] " Srivatsa Vaddagiri
2004-04-06 8:37 ` Srivatsa Vaddagiri
2004-04-06 9:26 ` Nick Piggin
2004-04-06 14:56 ` Srivatsa Vaddagiri
2004-04-06 15:04 ` Nick Piggin
2004-04-06 15:20 ` Srivatsa Vaddagiri
2004-04-07 3:54 ` Rusty Russell
2004-04-07 4:11 ` Nick Piggin
2004-04-07 5:01 ` Srivatsa Vaddagiri
2004-04-07 5:32 ` Rusty Russell
2004-04-07 14:17 ` Srivatsa Vaddagiri
2004-04-07 22:55 ` Rusty Russell
2004-04-12 16:08 ` [lhcs-devel] " Srivatsa Vaddagiri
2004-04-06 7:25 ` Ingo Molnar
2004-04-06 14:53 ` Srivatsa Vaddagiri [this message]
2004-04-06 15:03 ` Srivatsa Vaddagiri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040406145348.GA8516@in.ibm.com \
--to=vatsa@in.ibm.com \
--cc=akpm@osdl.org \
--cc=lhcs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=nickpiggin@yahoo.com.au \
--cc=rusty@au1.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).