linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Lightfoot <jeffml@pobox.com>
To: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2.6] net/sk98lin: correct buggy VPD in ASUS MB
Date: Tue, 6 Apr 2004 17:50:12 -0700	[thread overview]
Message-ID: <20040406175012.64fe9d7c.jeffml@pobox.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 572 bytes --]

The following patch to net/sk98lin/skvpd.c was put together by Marc
Bouget, mbouget at club-internet.fr.  He currently doesn't have time to
interface with linux-kernel so I offered to work that front.

This patch works around a corrupt EEPROM (VPD?) in the ASUS K8V Deluxe
SE motherboard ethernet chipset and allows the network driver to work
correctly.  We have written to ASUS and the sk98lin maintainers but have
not heard anything back.

Does this have a chance to be included in mainline or is there a
preferable way to fix these kind of issues?

  -- Jeff Lightfoot

[-- Attachment #2: skvpd.c.diff --]
[-- Type: text/plain, Size: 746 bytes --]

--- drivers/net/sk98lin/skvpd.c.orig	2004-04-05 17:32:59.000000000 -0700
+++ drivers/net/sk98lin/skvpd.c	2004-04-05 17:33:26.000000000 -0700
@@ -468,6 +468,16 @@
 	
 	pAC->vpd.vpd_size = vpd_size;
 
+	/* Asus K8V Se Deluxe bugfix. Correct VPD content */
+	/* MBo April 2004 */
+	if( ((unsigned char)pAC->vpd.vpd_buf[0x3f] == 0x38) &&
+	    ((unsigned char)pAC->vpd.vpd_buf[0x40] == 0x3c) &&
+	    ((unsigned char)pAC->vpd.vpd_buf[0x41] == 0x45) ) {
+		printk("sk98lin : humm... Asus mainboard with buggy VPD ? correcting data.\n");
+		(unsigned char)pAC->vpd.vpd_buf[0x40] = 0x38;
+	}
+
+
 	/* find the end tag of the RO area */
 	if (!(r = vpd_find_para(pAC, VPD_RV, &rp))) {
 		SK_DBG_MSG(pAC, SK_DBGMOD_VPD, SK_DBGCAT_ERR | SK_DBGCAT_FATAL,



             reply	other threads:[~2004-04-07  0:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-07  0:50 Jeff Lightfoot [this message]
2004-04-25  6:48 ` [PATCH 2.6] net/sk98lin: correct buggy VPD in ASUS MB J. Ryan Earl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040406175012.64fe9d7c.jeffml@pobox.com \
    --to=jeffml@pobox.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).