linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
To: "John Stoffel" <stoffel@lucent.com>
Cc: linux-kernel@vger.kernel.org, andre@linux-ide.org
Subject: Re: 2.6.5-rc3: cat /proc/ide/hpt366 kills disk on second channel
Date: Tue, 6 Apr 2004 19:00:36 +0200	[thread overview]
Message-ID: <200404061900.36497.bzolnier@elka.pw.edu.pl> (raw)
In-Reply-To: <16498.54669.886834.727923@gargle.gargle.HOWL>


Can you try this patch?

It seems somebody tried to do write access
from /proc handler without _any_ locking.

Regards,
Bartlomiej

--- linux-2.6.5/drivers/ide/pci/hpt366.c	2004-04-05 21:53:45.000000000 +0200
+++ linux/drivers/ide/pci/hpt366.c	2004-04-06 18:54:24.756073752 +0200
@@ -107,7 +107,7 @@
 				"                             %s\n",
 			(c0 & 0x80) ? "no" : "yes",
 			(c1 & 0x80) ? "no" : "yes");
-
+#if 0
 		if (hpt_minimum_revision(dev, 3)) {
 			u8 cbl;
 			cbl = inb(iobase + 0x7b);
@@ -120,7 +120,7 @@
 				(cbl & 0x01) ? 33 : 66);
 			p += sprintf(p, "\n");
 		}
-
+#endif
 		p += sprintf(p, "--------------- drive0 --------- drive1 "
 				"------- drive0 ---------- drive1 -------\n");
 		p += sprintf(p, "DMA capable:    %s              %s" 


  reply	other threads:[~2004-04-06 16:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-05  0:00 2.6.5-rc3: cat /proc/ide/hpt366 kills disk on second channel John Stoffel
2004-04-06 16:06 ` John Stoffel
2004-04-06 17:00   ` Bartlomiej Zolnierkiewicz [this message]
2004-04-06 18:35     ` John Stoffel
2004-04-06 20:01     ` John Stoffel
2004-04-06 21:02       ` Bartlomiej Zolnierkiewicz
2004-04-07 15:41         ` John Stoffel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200404061900.36497.bzolnier@elka.pw.edu.pl \
    --to=b.zolnierkiewicz@elka.pw.edu.pl \
    --cc=andre@linux-ide.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stoffel@lucent.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).