From: "Michael S. Tsirkin" <mst@mellanox.co.il>
To: linux-kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: f_ops flag to speed up compatible ioctls in linux kernel
Date: Thu, 2 Sep 2004 02:18:40 +0300 [thread overview]
Message-ID: <20040901231840.GF26044@mellanox.co.il> (raw)
In-Reply-To: <52sma1y4t7.fsf@topspin.com>
Quoting r. Roland Dreier (roland@topspin.com) "Re: f_ops flag to speed up compatible ioctls in linux kernel":
> Roland> Yes, this is exactly right. One issue raised by this
> Roland> thread is that the ioctl32 compatibility code only allows
> Roland> one compatibility handler per ioctl number. It seems that
> Roland> this creates all sorts of possibilities for mayhem because
> Roland> it makes the ioctl namespace global in scope in some
> Roland> situations. Does anyone have any thoughts on if/how this
> Roland> should be addressed?
>
> Michael> Thats what my original patch attempts to address
> Michael> http://www.uwsg.indiana.edu/hypermail/linux/kernel/0409.0/0025.html
> Michael> What do you think?
>
> That patch seems somewhat orthogonal to the issue I raised. You're
> just fixing the problem for devices that don't use the ioctl32 compat
> layer.
>
No I'm removing the need for ioctls to go through the compat layer.
No compat layer, no problem.
I see the compat layer as a hack to support legacy devices without touching
all of their code.
I dont see why a new driver would use the compat hacks instead of simply
building a 32/64 bit compatible interface, and legacy drivers have the
uniqueness for commands solved one way or another.
So the only interesting problem left is for new char devices.
MST
next prev parent reply other threads:[~2004-09-01 23:21 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-01 15:36 f_ops flag to speed up compatible ioctls in linux kernel Albert Cahalan
2004-09-01 15:59 ` Roland Dreier
2004-09-01 21:53 ` Michael S. Tsirkin
2004-09-01 22:58 ` Roland Dreier
2004-09-01 23:18 ` Michael S. Tsirkin [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-12-27 22:22 Michael S. Tsirkin
2004-09-01 15:40 Albert Cahalan
2004-09-01 21:23 ` Michael S. Tsirkin
2004-09-01 21:38 ` Lee Revell
2004-09-01 21:43 ` Chris Wright
2004-09-01 21:44 ` Roland Dreier
2004-09-01 9:50 filia
2004-09-01 9:52 ` Arjan van de Ven
2004-09-01 10:16 ` filia
[not found] ` <4135B9FC.7050602@hist.no>
2004-09-01 13:29 ` Ihar 'Philips' Filipau
2004-09-01 15:28 ` Ihar 'Philips' Filipau
2004-09-02 7:29 ` Helge Hafting
2004-09-01 13:43 ` Olivier Galibert
2004-09-01 7:22 Michael S. Tsirkin
2004-09-01 7:32 ` viro
2004-09-01 7:44 ` Michael S. Tsirkin
2004-09-01 7:47 ` Lee Revell
2004-09-01 8:19 ` Michael S. Tsirkin
2004-09-01 15:55 ` Roland Dreier
2004-09-01 18:02 ` Chris Wright
2004-09-01 18:12 ` Roland Dreier
2004-09-01 18:31 ` viro
2004-09-01 20:54 ` Roland Dreier
[not found] ` <20040901170800.K1924@build.pdx.osdl.net>
[not found] ` <20040901190122.L1924@build.pdx.osdl.net>
2004-09-02 3:46 ` Roland Dreier
2004-09-01 18:06 ` Bill Davidsen
2004-09-01 8:30 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040901231840.GF26044@mellanox.co.il \
--to=mst@mellanox.co.il \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).