From: Francois Romieu <romieu@fr.zoreil.com>
To: Jason McMullan <jason.mcmullan@timesys.com>
Cc: linux-kernel@vger.kernel.org, jgarzik@pobox.com
Subject: Re: [PATCH] MII bus API for PHY devices
Date: Thu, 11 Nov 2004 22:31:30 +0100 [thread overview]
Message-ID: <20041111213130.GA13327@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <20041111194526.GA17735@jmcmullan.timesys>
Jason McMullan <jason.mcmullan@timesys.com> :
> First patch for consolidation of PHY handling into one location.
A little pass of polish could make it more cool imho:
- macro abuse;
- unchecked malloc;
- use plain old style multi-lines C comments (/* ...\n * ... \n * ... \n */) ?
- whitespace/tabulation damage (search for series of 2 or more spaces);
- hidden return: please put them on a separate line;
- no need to BUG_ON when there is an immediate dereference;
- mixed case variables/names (pLEAse DO not dO tHAT);
- unneeded checks ? How could VALID_BUS() in mii_bus_write() fail ?
- use goto when locking primitives are used (btw the last check in
mii_bus_register is not needed and you can s/mii_bus[bus_id]/bus/
a few times in this function) ?
- add a break in mii_bus_unregister() ?
- I'd probably favor ternary operators here and there (your choice, really)
- u32 and uint16_t in the same file: choose one style ?
--
Ueimor
next prev parent reply other threads:[~2004-11-11 21:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-11 19:45 [PATCH] MII bus API for PHY devices Jason McMullan
2004-11-11 21:31 ` Francois Romieu [this message]
2004-11-11 22:48 Jason McMullan
2004-11-11 23:54 ` Francois Romieu
2004-11-12 0:07 ` Francois Romieu
2004-11-12 6:15 ` Benjamin Herrenschmidt
2004-11-12 16:47 ` Jason McMullan
2004-11-13 1:36 ` Benjamin Herrenschmidt
[not found] <069B6F33-341C-11D9-9652-000393DBC2E8@freescale.com>
2004-11-18 17:52 ` Andy Fleming
2004-11-18 19:34 ` Jason McMullan
2004-11-18 19:50 ` Andy Fleming
2004-11-18 21:00 ` Jason McMullan
2004-11-18 23:26 ` Benjamin Herrenschmidt
2004-11-19 16:41 ` Jason McMullan
2004-11-19 21:18 ` Andy Fleming
2004-11-19 22:43 ` Benjamin Herrenschmidt
2004-11-20 0:04 ` Andy Fleming
2004-11-19 20:18 Manfred Spraul
2004-11-19 21:01 ` Andy Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041111213130.GA13327@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=jason.mcmullan@timesys.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).