From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262647AbUKMMUL (ORCPT ); Sat, 13 Nov 2004 07:20:11 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262666AbUKMMUL (ORCPT ); Sat, 13 Nov 2004 07:20:11 -0500 Received: from dns1.atmark-techno.com ([210.191.215.170]:11527 "EHLO dns1.atmark-techno.com") by vger.kernel.org with ESMTP id S262647AbUKMMUF (ORCPT ); Sat, 13 Nov 2004 07:20:05 -0500 Date: Sat, 13 Nov 2004 21:20:03 +0900 From: Yasushi SHOJI To: Linus Torvalds Cc: adaplas@pol.net, Linux Fbdev development list , Benjamin Herrenschmidt , Linux Kernel list , Andrew Morton , uClinux development list Subject: Re: [Linux-fbdev-devel] Re: [PATCH] fbdev: Fix IO access in rivafb In-Reply-To: References: <200411080521.iA85LbG6025914@hera.kernel.org> <1099893447.10262.154.camel@gaston> <200411081706.55261.adaplas@hotpop.com> User-Agent: User-Agent: Wanderlust/2.10.1 MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Message-Id: <20041113122003.0CA8A3E90C@dns1.atmark-techno.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Hi Linus, At Mon, 8 Nov 2004 07:21:53 -0800 (PST), Linus Torvalds wrote: > > On Mon, 8 Nov 2004, Antonino A. Daplas wrote: > > > > How about this patch? This is almost the original macro in riva_hw.h, > > with the __force annotation. > > Why not just use __raw_readl/__raw_writel? > > That's what they exist for, and they still do any IO accesses correctly, > which a direct store does not do (it would seriously break on older > alphas, for example). sorry for a dumb question but should readl/writel on big endian system swap like ppc does? hmm... checking source code, it seems like most arch indeed does that, except m68knommu, h8300 and microblaze. is it nommu thing? -- yashi