From: Willy Tarreau <willy@w.ods.org>
To: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
Cc: linux-kernel@vger.kernel.org, gibbs@scsiguy.com
Subject: Re: Linux 2.4.28-rc3
Date: Sun, 14 Nov 2004 11:35:03 +0100 [thread overview]
Message-ID: <20041114103503.GA23021@alpha.home.local> (raw)
In-Reply-To: <20041112180052.GE23215@logos.cnet>
Hi Marcelo,
On Fri, Nov 12, 2004 at 04:00:52PM -0200, Marcelo Tosatti wrote:
> Here goes the third release candidate.
Just compiled it right now (with Adrian's patch applied).
results :
- it builds and runs on athlon SMP+scsi (aic7xxx)
- it builds and runs on sparc64 SMP+scsi (ncr), except for aic7xxx,
which needs the attached patch to remove an unused function (aic7xxx
compiles with -Werror).
Regards,
Willy
AIC7xxx build error on sparc64 :
sparc64-linux-gcc -D__KERNEL__ -I/usr/src/linux-2.4.28-rc3-fix/include -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -fomit-frame-pointer -m64 -pipe -mno-fpu -mcpu=ultrasparc -mcmodel=medlow -ffixed-g4 -fcall-used-g5 -fcall-used-g7 -Wno-sign-compare -Wa,--undeclared-regs -finline-limit=100000 -DMODULE -I/usr/src/linux-2.4.28-rc3-fix/drivers/scsi -Werror -nostdinc -iwithprefix include -DKBUILD_BASENAME=aic79xx_osm_pci -c -o aic79xx_osm_pci.o aic79xx_osm_pci.c
cc1: warnings being treated as errors
aic79xx_osm_pci.c:278: warning: `ahd_linux_pci_reserve_mem_region' defined but not used
make[1]: *** [aic79xx_osm_pci.o] Error 1
make[1]: Leaving directory `/usr/src/linux-2.4.28-rc3-fix/drivers/scsi/aic7xxx'
make: *** [_mod_drivers/scsi/aic7xxx] Error 2
Trivial patch (the function is used only if MMAPIO is defined) :
--- ./drivers/scsi/aic7xxx/aic79xx_osm_pci.c.orig Sun Nov 14 10:17:41 2004
+++ ./drivers/scsi/aic7xxx/aic79xx_osm_pci.c Sun Nov 14 10:19:35 2004
@@ -52,9 +52,12 @@
const struct pci_device_id *ent);
static int ahd_linux_pci_reserve_io_regions(struct ahd_softc *ahd,
u_long *base, u_long *base2);
+#ifdef MMAPIO
static int ahd_linux_pci_reserve_mem_region(struct ahd_softc *ahd,
u_long *bus_addr,
uint8_t **maddr);
+#endif
+
#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,4,0)
static void ahd_linux_pci_dev_remove(struct pci_dev *pdev);
@@ -271,6 +274,7 @@
return (0);
}
+#ifdef MMAPIO
static int
ahd_linux_pci_reserve_mem_region(struct ahd_softc *ahd,
u_long *bus_addr,
@@ -318,6 +322,7 @@
error = ENOMEM;
return (error);
}
+#endif
int
ahd_pci_map_registers(struct ahd_softc *ahd)
prev parent reply other threads:[~2004-11-14 10:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-12 18:00 Linux 2.4.28-rc3 Marcelo Tosatti
2004-11-13 16:27 ` Andrey Melnikoff
2004-11-13 15:24 ` Marcelo Tosatti
2005-01-19 17:50 ` megaraid2.c PATCH (was: Linux 2.4.28-rc3) Andrey J. Melnikoff (TEMHOTA)
2005-01-19 15:56 ` Marcelo Tosatti
2004-11-13 20:07 ` [patch] 2.4.28-rc3: neigh_for_each must be EXPORT_SYMBOL'ed Adrian Bunk
2004-11-14 7:25 ` David S. Miller
2004-11-14 10:35 ` Willy Tarreau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041114103503.GA23021@alpha.home.local \
--to=willy@w.ods.org \
--cc=gibbs@scsiguy.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).