From: Roger Luethi <rl@hellgate.ch>
To: Greg KH <greg@kroah.com>
Cc: linux-kernel@vger.kernel.org
Subject: [2.6 PATCH] visor: Always do generic_startup
Date: Tue, 16 Nov 2004 16:49:43 +0100 [thread overview]
Message-ID: <20041116154943.GA13874@k3.hellgate.ch> (raw)
generic_startup in visor.c was not called for some hardware, resulting
in attempts to access memory that had never been allocated, which in
turn caused the problem several people reported with recent (2.6.10ish)
kernels.
Signed-off-by: Roger Luethi <rl@hellgate.ch>
--- linux-2.6.10-rc2/drivers/usb/serial/visor.c.orig 2004-11-16 16:03:05.000000000 +0100
+++ linux-2.6.10-rc2/drivers/usb/serial/visor.c 2004-11-16 16:31:24.235249944 +0100
@@ -930,7 +930,7 @@ static int treo_attach (struct usb_seria
if (!((serial->dev->descriptor.idVendor == HANDSPRING_VENDOR_ID) ||
(serial->dev->descriptor.idVendor == KYOCERA_VENDOR_ID)) ||
(serial->num_interrupt_in == 0))
- return 0;
+ goto generic_startup;
dbg("%s", __FUNCTION__);
@@ -957,6 +957,7 @@ static int treo_attach (struct usb_seria
COPY_PORT(serial->port[1], swap_port);
kfree(swap_port);
+generic_startup:
return generic_startup(serial);
}
next reply other threads:[~2004-11-16 15:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-16 15:49 Roger Luethi [this message]
2004-11-19 17:44 ` [2.6 PATCH] visor: Always do generic_startup Greg KH
2004-11-21 1:23 ` Simon Fowler
2004-11-21 4:08 ` Greg KH
2004-11-21 7:15 ` Simon Fowler
2004-11-22 18:54 ` Greg KH
2004-11-23 19:36 ` [2.6 PATCH] visor: Don't count outstanding URBs twice Roger Luethi
2004-11-23 19:45 ` Greg KH
2004-11-23 20:30 ` Roger Luethi
2004-11-24 0:40 ` Simon Fowler
2004-11-24 23:25 ` Greg KH
2004-11-25 16:16 ` [2.6 PATCH] visor: Make URB limit error more visible Roger Luethi
2004-11-25 18:06 ` Greg KH
2004-11-28 17:11 ` Alan Cox
2004-11-30 0:06 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041116154943.GA13874@k3.hellgate.ch \
--to=rl@hellgate.ch \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).