From: Rolf Eike Beer <eike-kernel@sf-tec.de>
To: Greg KH <greg@kroah.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Documentation/pci.txt inconsistency
Date: Thu, 18 Nov 2004 10:45:01 +0100 [thread overview]
Message-ID: <200411181045.01691@bilbo.math.uni-mannheim.de> (raw)
In-Reply-To: <20041117220310.GB1291@kroah.com>
Greg KH wrote:
> On Wed, Nov 17, 2004 at 01:34:56PM +0100, Rolf Eike Beer wrote:
> > The examples in section 2 of Documentation/pci.txt use pci_get_*. Some
> > lines
> >
> > later there is this funny little paragraph:
> > > Note that these functions are not hotplug-safe. Their hotplug-safe
> > > replacements are pci_get_device(), pci_get_class() and
> > > pci_get_subsys(). They increment the reference count on the pci_dev
> > > that they return. You must eventually (possibly at module unload)
> > > decrement the reference count on these devices by calling
> > > pci_dev_put().
> >
> > How about this:
> >
> > These functions are hotplug-safe. They increment the reference count on
> > the pci_dev that they return. You must eventually (possibly at module
> > unload) decrement the reference count on these devices by calling
> > pci_dev_put().
>
> Great, care to send a patch instead?
Signed-off-by: Rolf Eike Beer <eike-kernel@sf-tec.de>
--- linux-2.6.9/Documentation/pci.txt 2004-11-18 09:43:56.927721824 +0100
+++ linux-2.6.10-rc2/Documentation/pci.txt 2004-11-18 10:09:06.070297280 +0100
@@ -156,11 +156,9 @@
VENDOR_ID or DEVICE_ID. This allows searching for any device from a
specific vendor, for example.
-Note that these functions are not hotplug-safe. Their hotplug-safe
-replacements are pci_get_device(), pci_get_class() and pci_get_subsys().
-They increment the reference count on the pci_dev that they return.
-You must eventually (possibly at module unload) decrement the reference
-count on these devices by calling pci_dev_put().
+ These functions are hotplug-safe. They increment the reference count on
+the pci_dev that they return. You must eventually (possibly at module unload)
+decrement the reference count on these devices by calling pci_dev_put().
3. Enabling and disabling devices
next prev parent reply other threads:[~2004-11-18 9:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-17 12:34 Documentation/pci.txt inconsistency Rolf Eike Beer
2004-11-17 22:03 ` Greg KH
2004-11-18 9:45 ` Rolf Eike Beer [this message]
2004-11-19 18:30 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200411181045.01691@bilbo.math.uni-mannheim.de \
--to=eike-kernel@sf-tec.de \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).