linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chuck Ebbert <76306.1226@compuserve.com>
To: Andi Kleen <ak@suse.de>
Cc: "kernel-stuff@comcast.net" <kernel-stuff@comcast.net>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Zwane Mwaikambo <zwane@linuxpower.ca>
Subject: Re: X86_64: Many Lost ticks
Date: Fri, 19 Nov 2004 03:19:34 -0500	[thread overview]
Message-ID: <200411190322_MC3-1-8EFA-5B2@compuserve.com> (raw)

On Thu, 18 Nov 2004 at 19:50:32 +0100, Andi Kleen wrote:

> On Thu, Nov 18, 2004 at 05:10:17PM +0000, Alan Cox wrote:
>
> > Ok ACPI timer override probably goes back into the broken bucket and out
> > of -ac in -ac11 then.
>
> The timer override should be fine (I have confirmation from Nvidia
> about this). The only thing that you can take out if you're conservative
> is the change to not disable the IOAPIC by default when Nvidia 
> is detected (in check_ioapic()) 


I did that long ago; the below patch is dated Oct 28 on my fileserver.

Alan could save himself some work if we shared patches... I already
backported even more of the networking stuff to 2.6.9 than he did.

# ioapic_on_nvidia_boards.patch
#
#       Originally suggested by Zwane Mwaikumbo
#
#       Ignore all ACPI timer overrides on all Nvidia boards.  The fallback doesn't
#       work and no Nvidia boards needs a timer override.  But some buggy BIOS have
#       it anyways.
#
#       Thanks to Andy Currid for confirming this.
#
#       Original patch enabled the IO-APIC.
#       Enable of IO-APIC removed by Chuck Ebbert <76306.1226@compuserve.com>
#
#       Signed-off-by: Andi Kleen <ak@suse.de>
#       Signed-off-by: Andrew Morton <akpm@osdl.org>
#       Signed-off-by: Chuck Ebbert <76306.1226@compuserve.com>
#
--- 2.6.9/arch/x86_64/kernel/io_apic.c
+++ 2.6.9.1/arch/x86_64/kernel/io_apic.c
@@ -271,6 +271,14 @@ void __init check_ioapic(void) 
                                               num,slot,vendor); 
                                        skip_ioapic_setup = 1;
 #endif
+#ifdef CONFIG_ACPI
+                                       /* All timer overrides on Nvidia
+                                          seem to be wrong. Skip them. */
+                                       printk(KERN_INFO 
+            "Nvidia board detected. Ignoring ACPI timer override.\n");
+                                       acpi_skip_timer_override = 1;
+                                       /* RED-PEN skip them on mptables too? */
+#endif
                                        return;
                                } 
 
--- 2.6.9/include/asm-x86_64/acpi.h
+++ 2.6.9.1/include/asm-x86_64/acpi.h
@@ -166,6 +166,8 @@ extern int acpi_pci_disabled;
 
 extern u8 x86_acpiid_to_apicid[];
 
+extern int acpi_skip_timer_override;
+
 #endif /*__KERNEL__*/
 
 #endif /*_ASM_ACPI_H*/

--Chuck Ebbert  19-Nov-04  03:19:18

             reply	other threads:[~2004-11-19  8:22 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-19  8:19 Chuck Ebbert [this message]
2004-11-19 16:11 ` X86_64: Many Lost ticks Zwane Mwaikambo
  -- strict thread matches above, loose matches on Subject: below --
2004-11-22 15:11 Chuck Ebbert
2004-11-18 19:30 kernel-stuff
2004-11-18 19:03 kernel-stuff
2004-11-18 17:19 kernel-stuff
2004-11-18 17:02 kernel-stuff
2004-11-18 17:08 ` Zwane Mwaikambo
2004-11-18 17:10 ` Alan Cox
2004-11-18 18:24   ` Zwane Mwaikambo
2004-11-18 18:50   ` Andi Kleen
2004-11-18 18:49 ` Andi Kleen
2004-11-19  1:56   ` kernel-stuff
2004-11-19 15:57     ` Zwane Mwaikambo
2004-11-20  0:17       ` kernel-stuff
2004-11-20  2:39     ` Alan Cox
2004-11-18  4:14 kernel-stuff
2004-11-18  4:02 kernel-stuff
2004-11-18  5:06 ` Andi Kleen
2004-11-18 15:54   ` Zwane Mwaikambo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200411190322_MC3-1-8EFA-5B2@compuserve.com \
    --to=76306.1226@compuserve.com \
    --cc=ak@suse.de \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=kernel-stuff@comcast.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zwane@linuxpower.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).