From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261369AbUKSMEu (ORCPT ); Fri, 19 Nov 2004 07:04:50 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261371AbUKSMDH (ORCPT ); Fri, 19 Nov 2004 07:03:07 -0500 Received: from hirsch.in-berlin.de ([192.109.42.6]:45285 "EHLO hirsch.in-berlin.de") by vger.kernel.org with ESMTP id S261367AbUKSMAc (ORCPT ); Fri, 19 Nov 2004 07:00:32 -0500 X-Envelope-From: kraxel@bytesex.org Date: Fri, 19 Nov 2004 12:50:42 +0100 From: Gerd Knorr To: Takashi Iwai Cc: "Alexander E. Patrakov" , linux-kernel@vger.kernel.org, Rusty Russell Subject: Re: modprobe + request_module() deadlock Message-ID: <20041119115042.GA30334@bytesex> References: <20041117222949.GA9006@linuxtv.org> <1100749702.5865.39.camel@localhost.localdomain> <20041118135522.GA16910@linuxtv.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-GPG-Fingerprint: 79C4 EE94 CC44 6DD4 58C6 3088 DBB7 EC73 8750 D2C4 [1024D/8750D2C4] User-Agent: Mutt/1.5.6i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org > > But IMHO Rusty should provide a way to specify those "recommended" install > > lines in the modules themselves (so that they finally go > > to /lib/modules/`uname -r`/modules.alias or a similar autogenerated file), > > like that's already done wih aliases and char-majors. > > Well, how about to add a new marker in the driver code such as > > MODULE_DEPENDS_ON("somemodule"); > > so that depmod can pick it up? Wouldn't work for me as this isn't static. saa7134 has to look at the hardware, then decide whenever it should load saa7134-empress, saa7134-dvb or none of them. On the other hand I don't depend on request_module() waiting for the modprobe being finished. So maybe we can solve that with a request_module_async()? Gerd